jojo/models/fixtures/TestAddTeamReviewRequest/pull_request.yml

-
  id: 11
  type: 0 # gitea pull request
  status: 2 # mergeable
  issue_id: 23
  index: 3
  head_repo_id: 2
  base_repo_id: 2
  head_branch: feature/protected-branch-pr
  base_branch: protected-main
  merge_base: 4a357436d925b5c974181ff12a994538ddc5a269
  has_merged: false
fix: PR not blocked by review request for a whitelisted team (#8511) Fixes #8491. Previous behavior always updated the newly created review to set the `official` flag to false. This logic is now removed. The most likely reason that this logic existed was that team reviews were being marked as official based upon `doer`, rather than the target team, which seems undesirable. The expected behavior was retained by removing the check for `IsOfficialReviewer(..., doer)`, ensuring that when making a review request for a team, it doesn't matter who makes the request. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/8511 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Reviewed-by: Gusted <gusted@noreply.codeberg.org> Co-authored-by: Mathieu Fenniak <mathieu@fenniak.net> Co-committed-by: Mathieu Fenniak <mathieu@fenniak.net> 2025-07-15 23:21:42 +02:00			`-`
			`id: 11`
			`type: 0 # gitea pull request`
			`status: 2 # mergeable`
			`issue_id: 23`
			`index: 3`
			`head_repo_id: 2`
			`base_repo_id: 2`
			`head_branch: feature/protected-branch-pr`
			`base_branch: protected-main`
			`merge_base: 4a357436d925b5c974181ff12a994538ddc5a269`
			`has_merged: false`