2025-11-30 17:00:57 +01:00
|
|
|
---
|
2025-03-28 22:22:21 +00:00
|
|
|
version: "2"
|
|
|
|
|
output:
|
|
|
|
|
sort-order:
|
|
|
|
|
- file
|
2019-06-12 21:41:28 +02:00
|
|
|
linters:
|
2025-03-28 22:22:21 +00:00
|
|
|
default: none
|
2019-06-12 21:41:28 +02:00
|
|
|
enable:
|
2022-12-08 09:21:37 +01:00
|
|
|
- bidichk
|
|
|
|
|
- depguard
|
2019-06-12 21:41:28 +02:00
|
|
|
- dupl
|
2022-12-08 09:21:37 +01:00
|
|
|
- errcheck
|
Enable forbidigo linter (#24278)
Enable [forbidigo](https://github.com/ashanbrown/forbidigo) linter which
forbids print statements. Will check how to integrate this with the
smallest impact possible, so a few `nolint` comments will likely be
required. Plan is to just go through the issues and either:
- Remove the print if it is nonsensical
- Add a `//nolint` directive if it makes sense
I don't plan on investigating the individual issues any further.
<details>
<summary>Initial Lint Results</summary>
```
modules/log/event.go:348:6: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Println(err)
^
modules/log/event.go:382:6: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Println(err)
^
modules/queue/unique_queue_disk_channel_test.go:20:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("TempDir %s\n", tmpDir)
^
contrib/backport/backport.go:168:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("* Backporting %s to %s as %s\n", pr, localReleaseBranch, backportBranch)
^
contrib/backport/backport.go:216:4: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("* Navigate to %s to open PR\n", url)
^
contrib/backport/backport.go:223:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("* `xdg-open %s`\n", url)
^
contrib/backport/backport.go:233:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("* `git push -u %s %s`\n", remote, backportBranch)
^
contrib/backport/backport.go:243:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("* Amending commit to prepend `Backport #%s` to body\n", pr)
^
contrib/backport/backport.go:272:3: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Println("* Attempting git cherry-pick --continue")
^
contrib/backport/backport.go:281:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("* Attempting git cherry-pick %s\n", sha)
^
contrib/backport/backport.go:297:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("* Current branch is %s\n", currentBranch)
^
contrib/backport/backport.go:299:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("* Current branch is %s - not checking out\n", currentBranch)
^
contrib/backport/backport.go:304:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("* Branch %s already exists. Checking it out...\n", backportBranch)
^
contrib/backport/backport.go:308:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("* `git checkout -b %s %s`\n", backportBranch, releaseBranch)
^
contrib/backport/backport.go:313:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("* `git fetch %s main`\n", remote)
^
contrib/backport/backport.go:316:3: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Println(string(out))
^
contrib/backport/backport.go:319:2: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Println(string(out))
^
contrib/backport/backport.go:321:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("* `git fetch %s %s`\n", remote, releaseBranch)
^
contrib/backport/backport.go:324:3: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Println(string(out))
^
contrib/backport/backport.go:327:2: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Println(string(out))
^
models/unittest/fixtures.go:50:3: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Println("Unsupported RDBMS for integration tests")
^
models/unittest/fixtures.go:89:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("LoadFixtures failed after retries: %v\n", err)
^
models/unittest/fixtures.go:110:4: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("Failed to generate sequence update: %v\n", err)
^
models/unittest/fixtures.go:117:6: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("Failed to update sequence: %s Error: %v\n", value, err)
^
models/migrations/base/tests.go:118:3: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Println("Environment variable $GITEA_ROOT not set")
^
models/migrations/base/tests.go:127:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("Could not find gitea binary at %s\n", setting.AppPath)
^
models/migrations/base/tests.go:134:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("Environment variable $GITEA_CONF not set - defaulting to %s\n", giteaConf)
^
models/migrations/base/tests.go:145:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("Unable to create temporary data path %v\n", err)
^
models/migrations/base/tests.go:154:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("Unable to InitFull: %v\n", err)
^
models/migrations/v1_11/v112.go:34:5: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("Error: %v", err)
^
contrib/fixtures/fixture_generation.go:36:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("CreateTestEngine: %+v", err)
^
contrib/fixtures/fixture_generation.go:40:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("PrepareTestDatabase: %+v\n", err)
^
contrib/fixtures/fixture_generation.go:46:5: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("generate '%s': %+v\n", r, err)
^
contrib/fixtures/fixture_generation.go:53:5: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("generate '%s': %+v\n", g.name, err)
^
contrib/fixtures/fixture_generation.go:71:4: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("%s created.\n", path)
^
services/gitdiff/gitdiff_test.go:543:2: use of `println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
println(result)
^
services/gitdiff/gitdiff_test.go:560:2: use of `println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
println(result)
^
services/gitdiff/gitdiff_test.go:577:2: use of `println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
println(result)
^
modules/web/routing/logger_manager.go:34:2: use of `print` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
print Printer
^
modules/doctor/paths.go:109:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("Warning: can't remove temporary file: '%s'\n", tmpFile.Name())
^
tests/test_utils.go:33:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf(format+"\n", args...)
^
tests/test_utils.go:61:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("Environment variable $GITEA_CONF not set, use default: %s\n", giteaConf)
^
cmd/actions.go:54:9: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
_, _ = fmt.Printf("%s\n", respText)
^
cmd/admin_user_change_password.go:74:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("%s's password has been successfully updated!\n", user.Name)
^
cmd/admin_user_create.go:109:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("generated random password is '%s'\n", password)
^
cmd/admin_user_create.go:164:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("Access token was successfully created... %s\n", t.Token)
^
cmd/admin_user_create.go:167:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("New user '%s' has been successfully created!\n", username)
^
cmd/admin_user_generate_access_token.go:74:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("%s\n", t.Token)
^
cmd/admin_user_generate_access_token.go:76:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("Access token was successfully created: %s\n", t.Token)
^
cmd/admin_user_must_change_password.go:56:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("Updated %d users setting MustChangePassword to %t\n", n, mustChangePassword)
^
cmd/convert.go:44:3: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Println("Converted successfully, please confirm your database's character set is now utf8mb4")
^
cmd/convert.go:50:3: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Println("Converted successfully, please confirm your database's all columns character is NVARCHAR now")
^
cmd/convert.go:52:3: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Println("This command can only be used with a MySQL or MSSQL database")
^
cmd/doctor.go:104:3: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Println(err)
^
cmd/doctor.go:105:3: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Println("Check if you are using the right config file. You can use a --config directive to specify one.")
^
cmd/doctor.go:243:3: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Println(err)
^
cmd/embedded.go:154:3: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Println(a.path)
^
cmd/embedded.go:198:3: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Println("Using app.ini at", setting.CustomConf)
^
cmd/embedded.go:217:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("Extracting to %s:\n", destdir)
^
cmd/embedded.go:253:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("%s already exists; skipped.\n", dest)
^
cmd/embedded.go:275:2: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Println(dest)
^
cmd/generate.go:63:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("%s", internalToken)
^
cmd/generate.go:66:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("\n")
^
cmd/generate.go:78:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("%s", JWTSecretBase64)
^
cmd/generate.go:81:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("\n")
^
cmd/generate.go:93:2: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("%s", secretKey)
^
cmd/generate.go:96:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("\n")
^
cmd/keys.go:74:2: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Println(strings.TrimSpace(authorizedString))
^
cmd/mailer.go:32:4: use of `fmt.Print` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Print("warning: Content is empty")
^
cmd/mailer.go:35:3: use of `fmt.Print` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Print("Proceed with sending email? [Y/n] ")
^
cmd/mailer.go:40:4: use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Println("The mail was not sent")
^
cmd/mailer.go:49:9: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
_, _ = fmt.Printf("Sent %s email(s) to all users\n", respText)
^
cmd/serv.go:147:3: use of `println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
println("Gitea: SSH has been disabled")
^
cmd/serv.go:153:4: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("error showing subcommand help: %v\n", err)
^
cmd/serv.go:175:4: use of `println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
println("Hi there! You've successfully authenticated with the deploy key named " + key.Name + ", but Gitea does not provide shell access.")
^
cmd/serv.go:177:4: use of `println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
println("Hi there! You've successfully authenticated with the principal " + key.Content + ", but Gitea does not provide shell access.")
^
cmd/serv.go:179:4: use of `println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
println("Hi there, " + user.Name + "! You've successfully authenticated with the key named " + key.Name + ", but Gitea does not provide shell access.")
^
cmd/serv.go:181:3: use of `println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
println("If this is unexpected, please log in with password and setup Gitea under another user.")
^
cmd/serv.go:196:5: use of `fmt.Print` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Print(`{"type":"gitea","version":1}`)
^
tests/e2e/e2e_test.go:54:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("Error initializing test database: %v\n", err)
^
tests/e2e/e2e_test.go:63:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("util.RemoveAll: %v\n", err)
^
tests/e2e/e2e_test.go:67:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("Unable to remove repo indexer: %v\n", err)
^
tests/e2e/e2e_test.go:109:6: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("%v", stdout.String())
^
tests/e2e/e2e_test.go:110:6: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("%v", stderr.String())
^
tests/e2e/e2e_test.go:113:6: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("%v", stdout.String())
^
tests/integration/integration_test.go:124:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("Error initializing test database: %v\n", err)
^
tests/integration/integration_test.go:135:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("util.RemoveAll: %v\n", err)
^
tests/integration/integration_test.go:139:3: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("Unable to remove repo indexer: %v\n", err)
^
tests/integration/repo_test.go:357:4: use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
fmt.Printf("%s", resp.Body)
^
```
</details>
---------
Co-authored-by: Giteabot <teabot@gitea.io>
2023-04-24 11:50:58 +02:00
|
|
|
- forbidigo
|
2022-03-21 06:22:34 +03:00
|
|
|
- gocritic
|
2022-12-08 09:21:37 +01:00
|
|
|
- govet
|
2025-11-30 17:00:57 +01:00
|
|
|
- importas
|
2022-12-08 09:21:37 +01:00
|
|
|
- ineffassign
|
2026-04-02 16:54:46 +02:00
|
|
|
- modernize
|
2022-06-20 12:02:49 +02:00
|
|
|
- nakedret
|
|
|
|
|
- nolintlint
|
2022-12-08 09:21:37 +01:00
|
|
|
- revive
|
|
|
|
|
- staticcheck
|
2024-07-30 19:41:10 +00:00
|
|
|
- testifylint
|
2022-12-08 09:21:37 +01:00
|
|
|
- unconvert
|
2024-06-11 20:47:45 +02:00
|
|
|
- unparam
|
2025-03-28 22:22:21 +00:00
|
|
|
- unused
|
2025-03-04 21:38:35 +00:00
|
|
|
- usetesting
|
2023-04-22 20:53:00 +02:00
|
|
|
- wastedassign
|
2026-02-11 19:08:24 +01:00
|
|
|
- nilnil
|
2025-03-28 22:22:21 +00:00
|
|
|
settings:
|
|
|
|
|
depguard:
|
|
|
|
|
rules:
|
|
|
|
|
main:
|
|
|
|
|
deny:
|
|
|
|
|
- pkg: encoding/json
|
|
|
|
|
desc: use gitea's modules/json instead of encoding/json
|
|
|
|
|
- pkg: golang.org/x/exp
|
|
|
|
|
desc: it's experimental and unreliable
|
|
|
|
|
- pkg: forgejo.org/modules/git/internal
|
|
|
|
|
desc: do not use the internal package, use AddXxx function instead
|
|
|
|
|
- pkg: gopkg.in/ini.v1
|
|
|
|
|
desc: do not use the ini package, use gitea's config system instead
|
|
|
|
|
- pkg: github.com/minio/sha256-simd
|
|
|
|
|
desc: use crypto/sha256 instead, see https://codeberg.org/forgejo/forgejo/pulls/1528
|
2025-07-15 00:20:00 +02:00
|
|
|
- pkg: github.com/go-git/go-git
|
|
|
|
|
desc: use forgejo.org/modules/git instead, see https://codeberg.org/forgejo/forgejo/pulls/4941
|
2025-08-21 14:17:43 +02:00
|
|
|
- pkg: gopkg.in/yaml.v3
|
|
|
|
|
desc: use go.yaml.in/yaml instead, see https://codeberg.org/forgejo/forgejo/pulls/8956
|
2026-04-01 02:57:09 +02:00
|
|
|
migration-isolation:
|
|
|
|
|
list-mode: lax
|
|
|
|
|
files:
|
|
|
|
|
- "**/models/forgejo_migrations/**"
|
|
|
|
|
deny:
|
|
|
|
|
- pkg: "forgejo.org/models"
|
|
|
|
|
desc: >
|
|
|
|
|
Migrations must not import application models. Application models will be the most recent schema for
|
|
|
|
|
Forgejo, while migrations will be operating against the database schema that existed when they were
|
|
|
|
|
authored.
|
|
|
|
|
- pkg: "forgejo.org/services"
|
|
|
|
|
desc: >
|
|
|
|
|
Migrations must not import application services. Application services will reference application
|
|
|
|
|
models which will use the most recent schema for Forgejo, while migrations will be operating against the
|
|
|
|
|
database schema that existed when they were authored.
|
|
|
|
|
allow:
|
|
|
|
|
- "forgejo.org/models/db"
|
|
|
|
|
- "forgejo.org/models/gitea_migrations/base"
|
|
|
|
|
- "forgejo.org/models/gitea_migrations/test"
|
2025-03-28 22:22:21 +00:00
|
|
|
gocritic:
|
|
|
|
|
disabled-checks:
|
|
|
|
|
- ifElseChain
|
2025-11-30 17:00:57 +01:00
|
|
|
importas:
|
|
|
|
|
alias:
|
|
|
|
|
# Specific overrides that would violate the default rules further below.
|
|
|
|
|
- pkg: forgejo.org/models/db
|
|
|
|
|
alias: ""
|
|
|
|
|
- pkg: forgejo.org/models/organization
|
|
|
|
|
alias: org_model
|
|
|
|
|
|
|
|
|
|
- pkg: forgejo.org/services/context
|
|
|
|
|
alias: app_context
|
|
|
|
|
- pkg: forgejo.org/services/doctor
|
|
|
|
|
alias: doctor
|
|
|
|
|
- pkg: forgejo.org/services/repository
|
|
|
|
|
alias: repo_service
|
|
|
|
|
|
|
|
|
|
# Make sure that we follow a consistent naming for model and service aliases.
|
2025-12-09 14:34:06 +01:00
|
|
|
- pkg: 'forgejo.org/(model|service)s/(\w+)'
|
2025-11-30 17:00:57 +01:00
|
|
|
alias: '${2}_${1}'
|
|
|
|
|
|
2025-03-28 22:22:21 +00:00
|
|
|
revive:
|
|
|
|
|
severity: error
|
|
|
|
|
rules:
|
|
|
|
|
- name: atomic
|
|
|
|
|
- name: bare-return
|
|
|
|
|
- name: blank-imports
|
|
|
|
|
- name: constant-logical-expr
|
|
|
|
|
- name: context-as-argument
|
|
|
|
|
- name: context-keys-type
|
|
|
|
|
- name: dot-imports
|
|
|
|
|
- name: duplicated-imports
|
|
|
|
|
- name: empty-lines
|
|
|
|
|
- name: error-naming
|
|
|
|
|
- name: error-return
|
|
|
|
|
- name: error-strings
|
|
|
|
|
- name: errorf
|
|
|
|
|
- name: exported
|
|
|
|
|
- name: identical-branches
|
|
|
|
|
- name: if-return
|
|
|
|
|
- name: increment-decrement
|
|
|
|
|
- name: indent-error-flow
|
|
|
|
|
- name: modifies-value-receiver
|
|
|
|
|
- name: package-comments
|
|
|
|
|
- name: range
|
|
|
|
|
- name: receiver-naming
|
|
|
|
|
- name: redefines-builtin-id
|
|
|
|
|
- name: string-of-int
|
|
|
|
|
- name: superfluous-else
|
|
|
|
|
- name: time-naming
|
|
|
|
|
- name: unconditional-recursion
|
|
|
|
|
- name: unexported-return
|
|
|
|
|
- name: unreachable-code
|
|
|
|
|
- name: var-declaration
|
|
|
|
|
- name: var-naming
|
2025-07-05 18:33:45 +02:00
|
|
|
arguments:
|
|
|
|
|
- []
|
|
|
|
|
- []
|
|
|
|
|
- - skip-package-name-checks: true
|
2025-03-28 22:22:21 +00:00
|
|
|
- name: redefines-builtin-id
|
|
|
|
|
disabled: true
|
|
|
|
|
staticcheck:
|
|
|
|
|
checks:
|
|
|
|
|
- all
|
|
|
|
|
testifylint:
|
|
|
|
|
disable:
|
2025-10-08 13:15:33 +02:00
|
|
|
- error-is-as
|
2025-03-28 22:22:21 +00:00
|
|
|
- go-require
|
2026-02-11 19:08:24 +01:00
|
|
|
nilnil:
|
|
|
|
|
only-two: false
|
2025-03-28 22:22:21 +00:00
|
|
|
exclusions:
|
|
|
|
|
generated: lax
|
|
|
|
|
presets:
|
|
|
|
|
- comments
|
|
|
|
|
- common-false-positives
|
|
|
|
|
- legacy
|
|
|
|
|
- std-error-handling
|
2023-07-09 13:58:06 +02:00
|
|
|
rules:
|
2025-03-28 22:22:21 +00:00
|
|
|
- linters:
|
|
|
|
|
- nolintlint
|
|
|
|
|
path: models/db/sql_postgres_with_schema.go
|
|
|
|
|
- linters:
|
|
|
|
|
- dupl
|
|
|
|
|
- errcheck
|
|
|
|
|
- gocyclo
|
|
|
|
|
- gosec
|
|
|
|
|
- staticcheck
|
|
|
|
|
- unparam
|
|
|
|
|
path: _test\.go
|
|
|
|
|
- linters:
|
|
|
|
|
- dupl
|
|
|
|
|
- errcheck
|
|
|
|
|
- gocyclo
|
|
|
|
|
- gosec
|
2025-10-14 09:26:08 -06:00
|
|
|
path: models/gitea_migrations/v
|
2025-03-28 22:22:21 +00:00
|
|
|
- linters:
|
|
|
|
|
- forbidigo
|
|
|
|
|
path: cmd
|
|
|
|
|
- linters:
|
|
|
|
|
- dupl
|
|
|
|
|
text: (?i)webhook
|
|
|
|
|
- linters:
|
|
|
|
|
- gocritic
|
|
|
|
|
text: (?i)`ID' should not be capitalized
|
|
|
|
|
- linters:
|
|
|
|
|
- deadcode
|
|
|
|
|
- unused
|
|
|
|
|
text: (?i)swagger
|
|
|
|
|
- linters:
|
|
|
|
|
- staticcheck
|
|
|
|
|
text: (?i)argument x is overwritten before first use
|
|
|
|
|
- linters:
|
|
|
|
|
- gocritic
|
|
|
|
|
text: '(?i)commentFormatting: put a space between `//` and comment text'
|
|
|
|
|
- linters:
|
|
|
|
|
- gocritic
|
|
|
|
|
text: '(?i)exitAfterDefer:'
|
|
|
|
|
- linters:
|
|
|
|
|
- staticcheck
|
|
|
|
|
text: "(ST1005|ST1003|QF1001):"
|
2026-02-11 19:08:24 +01:00
|
|
|
|
|
|
|
|
# TODO: eventually remove this section entirely
|
|
|
|
|
- path: cmd/admin_auth_ldap_test.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: cmd/admin_auth_oauth_test.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: cmd/admin_auth_pam_test.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: cmd/cmd.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: cmd/forgejo/actions.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: models/actions/run.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: models/actions/task.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: models/activities/action_list.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: models/asymkey/gpg_key_object_verification.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: models/auth/oauth2.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: models/db/collation.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: models/dbfs/dbfile.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: models/forgefed/federationhost_repository.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: models/forgejo_migrations_legacy/v32.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: models/forgejo_migrations_legacy/v32_test.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: models/db/context.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: models/git/branch_list.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: models/git/lfs_lock.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: models/git/protected_branch.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: models/git/protected_tag.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: models/issues/issue.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: models/issues/issue_xref.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: models/issues/review.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: models/organization/org_user.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: models/quota/rule.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: models/repo/archiver.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: models/repo/fork.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: models/repo/topic.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: models/user/email_address.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: models/user/list.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: models/user/user.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: models/repo/repo.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: models/user/user_repository.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: modules/git/commit.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: modules/git/foreachref/parser.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: modules/git/last_commit_cache.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: modules/git/log_name_status.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: modules/graceful/net_unix.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: modules/indexer/internal/bleve/util.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: modules/indexer/issues/util.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: modules/optional/serialization.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: modules/setting/storage.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: routers/api/packages/chef/auth.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: routers/api/packages/container/auth.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: routers/api/packages/nuget/auth.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: routers/api/packages/swift/swift.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: routers/web/auth/oauth.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: routers/web/repo/compare.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: routers/web/repo/release.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: routers/web/repo/setting/runners.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: routers/web/repo/setting/secrets.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: routers/web/repo/setting/variables.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: services/actions/context.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: services/actions/task.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: services/actions/trust.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: services/contexttest/context_tests.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: services/gitdiff/csv.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: services/issue/assignee.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: routers/api/packages/conan/auth.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: services/federation/signature_service.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: services/issue/commit.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: services/issue/issue.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: services/migrations/onedev.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: services/packages/cargo/index.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: services/pull/check.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: services/pull/comment.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: services/pull/merge.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: services/pull/review.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: services/remote/promote.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: services/repository/archiver/archiver.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: services/repository/generate_repo_commit.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
|
|
|
|
- path: services/repository/repository.go
|
|
|
|
|
linters:
|
|
|
|
|
- nilnil
|
2025-03-28 22:22:21 +00:00
|
|
|
paths:
|
|
|
|
|
- node_modules
|
|
|
|
|
- public
|
|
|
|
|
- web_src
|
|
|
|
|
- third_party$
|
|
|
|
|
- builtin$
|
|
|
|
|
- examples$
|
2019-06-12 21:41:28 +02:00
|
|
|
issues:
|
2022-09-20 11:39:00 +02:00
|
|
|
max-issues-per-linter: 0
|
|
|
|
|
max-same-issues: 0
|
2025-03-28 22:22:21 +00:00
|
|
|
formatters:
|
|
|
|
|
enable:
|
|
|
|
|
- gofmt
|
|
|
|
|
- gofumpt
|
|
|
|
|
settings:
|
|
|
|
|
gofumpt:
|
|
|
|
|
extra-rules: true
|
|
|
|
|
exclusions:
|
|
|
|
|
generated: lax
|
|
|
|
|
paths:
|
|
|
|
|
- node_modules
|
|
|
|
|
- public
|
|
|
|
|
- web_src
|
|
|
|
|
- third_party$
|
|
|
|
|
- builtin$
|
|
|
|
|
- examples$
|