2023-02-06 02:49:21 +01:00
|
|
|
// Copyright 2023 The Gitea Authors. All rights reserved.
|
|
|
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
|
|
|
|
|
|
package chef
|
|
|
|
|
|
|
|
|
|
import (
|
2023-09-15 08:13:19 +02:00
|
|
|
"context"
|
2023-02-06 02:49:21 +01:00
|
|
|
"crypto"
|
|
|
|
|
"crypto/rsa"
|
|
|
|
|
"crypto/sha1"
|
2023-09-30 00:45:31 +02:00
|
|
|
"crypto/sha256"
|
2023-02-06 02:49:21 +01:00
|
|
|
"crypto/x509"
|
|
|
|
|
"encoding/base64"
|
|
|
|
|
"encoding/pem"
|
2025-05-29 17:34:29 +02:00
|
|
|
"errors"
|
2023-02-06 02:49:21 +01:00
|
|
|
"fmt"
|
|
|
|
|
"hash"
|
|
|
|
|
"math/big"
|
|
|
|
|
"net/http"
|
|
|
|
|
"path"
|
|
|
|
|
"regexp"
|
2023-09-07 17:37:47 +08:00
|
|
|
"slices"
|
2023-02-06 02:49:21 +01:00
|
|
|
"strconv"
|
|
|
|
|
"strings"
|
|
|
|
|
"time"
|
|
|
|
|
|
2025-03-27 19:40:14 +00:00
|
|
|
user_model "forgejo.org/models/user"
|
|
|
|
|
chef_module "forgejo.org/modules/packages/chef"
|
|
|
|
|
"forgejo.org/modules/util"
|
|
|
|
|
"forgejo.org/services/auth"
|
2023-02-06 02:49:21 +01:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
const (
|
|
|
|
|
maxTimeDifference = 10 * time.Minute
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
var (
|
|
|
|
|
algorithmPattern = regexp.MustCompile(`algorithm=(\w+)`)
|
|
|
|
|
versionPattern = regexp.MustCompile(`version=(\d+\.\d+)`)
|
|
|
|
|
authorizationPattern = regexp.MustCompile(`\AX-Ops-Authorization-(\d+)`)
|
2023-09-05 17:58:30 +02:00
|
|
|
|
2026-05-08 04:07:32 +02:00
|
|
|
_ auth.Method = &Auth{}
|
|
|
|
|
_ auth.AuthenticationResult = &chefAuthenticationResult{}
|
2023-02-06 02:49:21 +01:00
|
|
|
)
|
|
|
|
|
|
2026-05-08 04:07:32 +02:00
|
|
|
type chefAuthenticationResult struct {
|
|
|
|
|
*auth.BaseAuthenticationResult
|
|
|
|
|
user *user_model.User
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (r *chefAuthenticationResult) User() *user_model.User {
|
|
|
|
|
return r.user
|
|
|
|
|
}
|
|
|
|
|
|
2023-02-06 02:49:21 +01:00
|
|
|
// Documentation:
|
|
|
|
|
// https://docs.chef.io/server/api_chef_server/#required-headers
|
|
|
|
|
// https://github.com/chef-boneyard/chef-rfc/blob/master/rfc065-sign-v1.3.md
|
|
|
|
|
// https://github.com/chef/mixlib-authentication/blob/bc8adbef833d4be23dc78cb23e6fe44b51ebc34f/lib/mixlib/authentication/signedheaderauth.rb
|
|
|
|
|
|
|
|
|
|
type Auth struct{}
|
|
|
|
|
|
|
|
|
|
func (a *Auth) Name() string {
|
|
|
|
|
return "chef"
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Verify extracts the user from the signed request
|
|
|
|
|
// If the request is signed with the user private key the user is verified.
|
2026-05-08 07:31:33 +02:00
|
|
|
func (a *Auth) Verify(req *http.Request, w http.ResponseWriter, sess auth.SessionStore) auth.MethodOutput {
|
2023-02-06 02:49:21 +01:00
|
|
|
u, err := getUserFromRequest(req)
|
|
|
|
|
if err != nil {
|
2026-05-08 07:31:33 +02:00
|
|
|
if !user_model.IsErrUserNotExist(err) {
|
|
|
|
|
return &auth.AuthenticationError{Error: fmt.Errorf("chef auth getUserFromRequest: %w", err)}
|
|
|
|
|
}
|
|
|
|
|
return &auth.AuthenticationAttemptedIncorrectCredential{Error: err}
|
2023-02-06 02:49:21 +01:00
|
|
|
}
|
|
|
|
|
if u == nil {
|
2026-05-08 07:31:33 +02:00
|
|
|
return &auth.AuthenticationNotAttempted{}
|
2023-02-06 02:49:21 +01:00
|
|
|
}
|
|
|
|
|
|
2023-09-15 08:13:19 +02:00
|
|
|
pub, err := getUserPublicKey(req.Context(), u)
|
2023-02-06 02:49:21 +01:00
|
|
|
if err != nil {
|
2026-05-08 07:31:33 +02:00
|
|
|
return &auth.AuthenticationError{Error: fmt.Errorf("chef auth getUserPublicKey: %w", err)}
|
2023-02-06 02:49:21 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if err := verifyTimestamp(req); err != nil {
|
2026-05-08 07:31:33 +02:00
|
|
|
return &auth.AuthenticationAttemptedIncorrectCredential{Error: err}
|
2023-02-06 02:49:21 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
version, err := getSignVersion(req)
|
|
|
|
|
if err != nil {
|
2026-05-08 07:31:33 +02:00
|
|
|
return &auth.AuthenticationAttemptedIncorrectCredential{Error: err}
|
2023-02-06 02:49:21 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if err := verifySignedHeaders(req, version, pub.(*rsa.PublicKey)); err != nil {
|
2026-05-08 07:31:33 +02:00
|
|
|
return &auth.AuthenticationAttemptedIncorrectCredential{Error: err}
|
2023-02-06 02:49:21 +01:00
|
|
|
}
|
|
|
|
|
|
2026-05-08 07:31:33 +02:00
|
|
|
return &auth.AuthenticationSuccess{Result: &chefAuthenticationResult{user: u}}
|
2023-02-06 02:49:21 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func getUserFromRequest(req *http.Request) (*user_model.User, error) {
|
|
|
|
|
username := req.Header.Get("X-Ops-Userid")
|
|
|
|
|
if username == "" {
|
|
|
|
|
return nil, nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return user_model.GetUserByName(req.Context(), username)
|
|
|
|
|
}
|
|
|
|
|
|
2023-09-15 08:13:19 +02:00
|
|
|
func getUserPublicKey(ctx context.Context, u *user_model.User) (crypto.PublicKey, error) {
|
|
|
|
|
pubKey, err := user_model.GetSetting(ctx, u.ID, chef_module.SettingPublicPem)
|
2023-02-06 02:49:21 +01:00
|
|
|
if err != nil {
|
|
|
|
|
return nil, err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
pubPem, _ := pem.Decode([]byte(pubKey))
|
|
|
|
|
|
|
|
|
|
return x509.ParsePKIXPublicKey(pubPem.Bytes)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func verifyTimestamp(req *http.Request) error {
|
|
|
|
|
hdr := req.Header.Get("X-Ops-Timestamp")
|
|
|
|
|
if hdr == "" {
|
|
|
|
|
return util.NewInvalidArgumentErrorf("X-Ops-Timestamp header missing")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
ts, err := time.Parse(time.RFC3339, hdr)
|
|
|
|
|
if err != nil {
|
|
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
diff := time.Now().UTC().Sub(ts)
|
|
|
|
|
if diff < 0 {
|
|
|
|
|
diff = -diff
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if diff > maxTimeDifference {
|
2025-05-29 17:34:29 +02:00
|
|
|
return errors.New("time difference")
|
2023-02-06 02:49:21 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func getSignVersion(req *http.Request) (string, error) {
|
|
|
|
|
hdr := req.Header.Get("X-Ops-Sign")
|
|
|
|
|
if hdr == "" {
|
|
|
|
|
return "", util.NewInvalidArgumentErrorf("X-Ops-Sign header missing")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
m := versionPattern.FindStringSubmatch(hdr)
|
|
|
|
|
if len(m) != 2 {
|
|
|
|
|
return "", util.NewInvalidArgumentErrorf("invalid X-Ops-Sign header")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
switch m[1] {
|
|
|
|
|
case "1.0", "1.1", "1.2", "1.3":
|
ci: detect and prevent empty `case` statements in Go code (#11593)
One of the security patches released 2026-03-09 [fixed a vulnerability](https://codeberg.org/forgejo/forgejo/pulls/11513/commits/d1c7b04d09f6a13896eaa1322ac690b2021539da) caused by a misapplication of Go `case` statements, where the implementation would have been correct if Go `case` statements automatically fall through to the next case block, but they do not. This PR adds a semgrep rule which detects any empty `case` statement and raises an error, in order to prevent this coding mistake in the future.
For example, code like this will now trigger a build error:
```go
switch setting.Protocol {
case setting.HTTPUnix:
case setting.FCGI:
case setting.FCGIUnix:
default:
defaultLocalURL := string(setting.Protocol) + "://"
}
```
Example error:
```
cmd/web.go
❯❯❱ semgrep.config.forgejo-switch-empty-case
switch has a case block with no content. This is treated as "break" by Go, but developers may
confuse it for "fallthrough". To fix this error, disambiguate by using "break" or
"fallthrough".
279┆ switch setting.Protocol {
280┆ case setting.HTTPUnix:
281┆ case setting.FCGI:
282┆ case setting.FCGIUnix:
283┆ default:
284┆ defaultLocalURL := string(setting.Protocol) + "://"
285┆ if setting.HTTPAddr == "0.0.0.0" {
286┆ defaultLocalURL += "localhost"
287┆ } else {
288┆ defaultLocalURL += setting.HTTPAddr
```
As described in the error output, this error can be fixed by explicitly listing `break` (the real Go behaviour, to do nothing in the block), or by listing `fallthrough` (if the intent was to fall through).
All existing code triggering this detection has been changed to `break` (or, rarely, irrelevant cases have been removed), which should maintain the same code functionality. While performing this fixup, a light analysis was performed on each case and they *appeared* correct, but with ~65 cases I haven't gone into extreme depth.
Tests are present for the semgrep rule in `.semgrep/tests/go.go`.
## Checklist
The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org).
### Documentation
- [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change.
- [x] I did not document these changes and I do not expect someone else to do it.
### Release notes
- [ ] This change will be noticed by a Forgejo user or admin (feature, bug fix, performance, etc.). I suggest to include a release note for this change.
- [x] This change is not visible to a Forgejo user or admin (refactor, dependency upgrade, etc.). I think there is no need to add a release note for this change.
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/11593
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: Mathieu Fenniak <mathieu@fenniak.net>
Co-committed-by: Mathieu Fenniak <mathieu@fenniak.net>
2026-03-10 02:50:28 +01:00
|
|
|
break
|
2023-02-06 02:49:21 +01:00
|
|
|
default:
|
|
|
|
|
return "", util.NewInvalidArgumentErrorf("unsupported version")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
version := m[1]
|
|
|
|
|
|
|
|
|
|
m = algorithmPattern.FindStringSubmatch(hdr)
|
2025-03-28 22:22:21 +00:00
|
|
|
if len(m) == 2 && m[1] != "sha1" && (m[1] != "sha256" || version != "1.3") {
|
2023-02-06 02:49:21 +01:00
|
|
|
return "", util.NewInvalidArgumentErrorf("unsupported algorithm")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return version, nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func verifySignedHeaders(req *http.Request, version string, pub *rsa.PublicKey) error {
|
|
|
|
|
authorizationData, err := getAuthorizationData(req)
|
|
|
|
|
if err != nil {
|
|
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
checkData := buildCheckData(req, version)
|
|
|
|
|
|
|
|
|
|
switch version {
|
|
|
|
|
case "1.3":
|
|
|
|
|
return verifyDataNew(authorizationData, checkData, pub, crypto.SHA256)
|
|
|
|
|
case "1.2":
|
|
|
|
|
return verifyDataNew(authorizationData, checkData, pub, crypto.SHA1)
|
|
|
|
|
default:
|
|
|
|
|
return verifyDataOld(authorizationData, checkData, pub)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func getAuthorizationData(req *http.Request) ([]byte, error) {
|
|
|
|
|
valueList := make(map[int]string)
|
|
|
|
|
for k, vs := range req.Header {
|
|
|
|
|
if m := authorizationPattern.FindStringSubmatch(k); m != nil {
|
|
|
|
|
index, _ := strconv.Atoi(m[1])
|
|
|
|
|
var v string
|
|
|
|
|
if len(vs) == 0 {
|
|
|
|
|
v = ""
|
|
|
|
|
} else {
|
|
|
|
|
v = vs[0]
|
|
|
|
|
}
|
|
|
|
|
valueList[index] = v
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
tmp := make([]string, len(valueList))
|
|
|
|
|
for k, v := range valueList {
|
|
|
|
|
if k > len(tmp) {
|
2025-05-29 17:34:29 +02:00
|
|
|
return nil, errors.New("invalid X-Ops-Authorization headers")
|
2023-02-06 02:49:21 +01:00
|
|
|
}
|
|
|
|
|
tmp[k-1] = v
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return base64.StdEncoding.DecodeString(strings.Join(tmp, ""))
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func buildCheckData(req *http.Request, version string) []byte {
|
|
|
|
|
username := req.Header.Get("X-Ops-Userid")
|
|
|
|
|
if version != "1.0" && version != "1.3" {
|
|
|
|
|
sum := sha1.Sum([]byte(username))
|
|
|
|
|
username = base64.StdEncoding.EncodeToString(sum[:])
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
var data string
|
|
|
|
|
if version == "1.3" {
|
|
|
|
|
data = fmt.Sprintf(
|
|
|
|
|
"Method:%s\nPath:%s\nX-Ops-Content-Hash:%s\nX-Ops-Sign:version=%s\nX-Ops-Timestamp:%s\nX-Ops-UserId:%s\nX-Ops-Server-API-Version:%s",
|
|
|
|
|
req.Method,
|
|
|
|
|
path.Clean(req.URL.Path),
|
|
|
|
|
req.Header.Get("X-Ops-Content-Hash"),
|
|
|
|
|
version,
|
|
|
|
|
req.Header.Get("X-Ops-Timestamp"),
|
|
|
|
|
username,
|
|
|
|
|
req.Header.Get("X-Ops-Server-Api-Version"),
|
|
|
|
|
)
|
|
|
|
|
} else {
|
|
|
|
|
sum := sha1.Sum([]byte(path.Clean(req.URL.Path)))
|
|
|
|
|
data = fmt.Sprintf(
|
|
|
|
|
"Method:%s\nHashed Path:%s\nX-Ops-Content-Hash:%s\nX-Ops-Timestamp:%s\nX-Ops-UserId:%s",
|
|
|
|
|
req.Method,
|
|
|
|
|
base64.StdEncoding.EncodeToString(sum[:]),
|
|
|
|
|
req.Header.Get("X-Ops-Content-Hash"),
|
|
|
|
|
req.Header.Get("X-Ops-Timestamp"),
|
|
|
|
|
username,
|
|
|
|
|
)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return []byte(data)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func verifyDataNew(signature, data []byte, pub *rsa.PublicKey, algo crypto.Hash) error {
|
|
|
|
|
var h hash.Hash
|
|
|
|
|
if algo == crypto.SHA256 {
|
|
|
|
|
h = sha256.New()
|
|
|
|
|
} else {
|
|
|
|
|
h = sha1.New()
|
|
|
|
|
}
|
|
|
|
|
if _, err := h.Write(data); err != nil {
|
|
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return rsa.VerifyPKCS1v15(pub, algo, h.Sum(nil), signature)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func verifyDataOld(signature, data []byte, pub *rsa.PublicKey) error {
|
|
|
|
|
c := new(big.Int)
|
|
|
|
|
m := new(big.Int)
|
|
|
|
|
m.SetBytes(signature)
|
|
|
|
|
e := big.NewInt(int64(pub.E))
|
|
|
|
|
c.Exp(m, e, pub.N)
|
|
|
|
|
|
|
|
|
|
out := c.Bytes()
|
|
|
|
|
|
|
|
|
|
skip := 0
|
|
|
|
|
for i := 2; i < len(out); i++ {
|
|
|
|
|
if i+1 >= len(out) {
|
|
|
|
|
break
|
|
|
|
|
}
|
|
|
|
|
if out[i] == 0xFF && out[i+1] == 0 {
|
|
|
|
|
skip = i + 2
|
|
|
|
|
break
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2023-09-07 17:37:47 +08:00
|
|
|
if !slices.Equal(out[skip:], data) {
|
2025-05-29 17:34:29 +02:00
|
|
|
return errors.New("could not verify signature")
|
2023-02-06 02:49:21 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return nil
|
|
|
|
|
}
|