From 555d88070d97fe56fce222bd081c3c3b08202991 Mon Sep 17 00:00:00 2001 From: Gusted Date: Sun, 3 May 2026 06:42:14 +0200 Subject: [PATCH] feat: migrate show-modal to native dialogs (#10287) Test coverage: |Modal|Test| |-|-| |admin: adopt unadopted|missing, not needed| |admin: delete unadopted|missing, not needed| |admin: delete user|e2e added: `Admin: delete a user`| |delete package|missing| |new project|?| |edit project col|?| |default project col|?| |delete project col|?| |commit cherry-pick|?| |commit delete note|?| |fork redirect|?| |lock/unlock issue|?| |dismiss PR review|?| |migration delete|?| |migration cancel|?| |lfs delete|?| |convert mirror|?| |convert fork|?| |transfer repo|?| |delete repo|?| |archive repo|integration present, selectors adjusted| |delete wiki|?| |rename wiki branch|?| |push mirror edit|?| |mde: new table|e2e present, selectors adjusted| |mde: new link|e2e present, selectors adjusted| |actions: add secret|?| |actions: edit variable|?| Co-authored-by: 0ko <0ko@noreply.codeberg.org> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/10287 Reviewed-by: 0ko <0ko@noreply.codeberg.org> --- templates/admin/repo/unadopted.tmpl | 60 ++-- templates/admin/user/edit.tmpl | 33 +- templates/package/settings.tmpl | 18 +- templates/projects/view.tmpl | 117 ++++--- templates/repo/commit_header.tmpl | 55 +-- templates/repo/header_fork.tmpl | 32 +- .../issue/view_content/sidebar/actions.tmpl | 90 ++--- .../view_content/sidebar/pull_reviewers.tmpl | 34 +- templates/repo/migrate/migrating.tmpl | 77 ++-- templates/repo/settings/lfs.tmpl | 18 +- templates/repo/settings/options.tmpl | 328 +++++++++--------- .../repo/settings/push_mirror_sync_modal.tmpl | 48 +-- templates/shared/combomarkdowneditor.tmpl | 82 ++--- templates/shared/secrets/add_list.tmpl | 118 +++---- templates/shared/variables/variable_list.tmpl | 61 ++-- tests/e2e/admin-ui.test.e2e.ts | 26 ++ tests/e2e/clipboard-copy.test.e2e.ts | 16 +- tests/e2e/issue-comment-dropzone.test.e2e.ts | 6 +- tests/e2e/issue-sidebar.test.e2e.ts | 7 +- tests/e2e/markdown-editor.test.e2e.ts | 14 +- tests/e2e/modal.test.e2e.ts | 24 -- tests/e2e/repo-code.test.e2e.ts | 12 +- tests/e2e/runner-management.test.e2e.ts | 47 ++- tests/integration/repo_archive_text_test.go | 2 +- web_src/js/features/common-global.js | 48 +-- .../js/features/comp/ComboMarkdownEditor.js | 38 +- web_src/js/features/repo-legacy.js | 4 +- web_src/js/features/show-modal.ts | 54 +++ web_src/js/modules/modal.ts | 13 +- web_src/js/types.d.ts | 6 + 30 files changed, 777 insertions(+), 711 deletions(-) create mode 100644 web_src/js/features/show-modal.ts diff --git a/templates/admin/repo/unadopted.tmpl b/templates/admin/repo/unadopted.tmpl index d7e57c7c14..bc74f24a58 100644 --- a/templates/admin/repo/unadopted.tmpl +++ b/templates/admin/repo/unadopted.tmpl @@ -24,37 +24,37 @@ {{svg "octicon-file-directory-fill"}} {{$dir}}
- + +
+
{{ctx.Locale.Tr "repo.adopt_preexisting"}}
+
+

{{ctx.Locale.Tr "repo.adopt_preexisting_content" $dir}}

+
+
+ + + + + {{template "base/modal_actions_confirm"}} +
+
+
- + +
+
{{ctx.Locale.Tr "repo.delete_preexisting"}}
+
+

{{ctx.Locale.Tr "repo.delete_preexisting_content" $dir}}

+
+
+ + + + + {{template "base/modal_actions_confirm"}} +
+
+
{{end}} diff --git a/templates/admin/user/edit.tmpl b/templates/admin/user/edit.tmpl index 1d29a991cd..f18317e694 100644 --- a/templates/admin/user/edit.tmpl +++ b/templates/admin/user/edit.tmpl @@ -224,24 +224,23 @@ - diff --git a/templates/projects/view.tmpl b/templates/projects/view.tmpl index 64def9cbca..3f7c91b35d 100644 --- a/templates/projects/view.tmpl +++ b/templates/projects/view.tmpl @@ -29,32 +29,31 @@ {{ctx.Locale.Tr "new_project_column"}} - - + +
{{ctx.Locale.Tr "repo.branch.new_branch"}}
@@ -284,20 +287,20 @@ - + +
+
{{end}}
diff --git a/templates/repo/header_fork.tmpl b/templates/repo/header_fork.tmpl index 0001be1025..95df5f4227 100644 --- a/templates/repo/header_fork.tmpl +++ b/templates/repo/header_fork.tmpl @@ -26,24 +26,24 @@ > {{svg "octicon-repo-forked"}}{{ctx.Locale.Tr "repo.fork"}} -