diff --git a/tests/e2e/declare_repos_test.go b/tests/e2e/declare_repos_test.go index 85e3fcbda8..e72f260299 100644 --- a/tests/e2e/declare_repos_test.go +++ b/tests/e2e/declare_repos_test.go @@ -117,7 +117,7 @@ body: }), }, []FileChanges{}, func(user *user_model.User, repo *repo_model.Repository) { postIssue(repo, user, 500, "first issue here", "an issue created earlier") - postIssue(repo, user, 400, "second issue here (not 1)", "not the right issue, but in the right repo") + postIssue(repo, user, 400, "second issue here", "not the right issue, but in the right repo") postIssue(repo, user, 300, "third issue here", "depends on things") postIssue(repo, user, 200, "unrelated issue", "shrug emoji") postIssue(repo, user, 100, "newest issue", "very new") diff --git a/tests/e2e/issue-sidebar.test.e2e.ts b/tests/e2e/issue-sidebar.test.e2e.ts index 3324595438..1a382c44d7 100644 --- a/tests/e2e/issue-sidebar.test.e2e.ts +++ b/tests/e2e/issue-sidebar.test.e2e.ts @@ -16,20 +16,18 @@ test.describe('Pull: Toggle WIP', () => { const prTitle = 'pull5'; async function toggle_wip_to({page}: {page: Page}, should: boolean) { - await page.waitForLoadState('domcontentloaded'); + const loadPromise = page.waitForEvent('load'); if (should) { await page.getByText('Still in progress?').click(); } else { await page.getByText('Ready for review?').click(); } + await loadPromise; } async function check_wip({page}: {page: Page}, is: boolean) { - await page.waitForLoadState(); - const elemTitle = 'h1'; const stateLabel = '.issue-state-label'; - await page.waitForLoadState('domcontentloaded'); await expect(page.locator(elemTitle)).toContainText(prTitle); await expect(page.locator(elemTitle)).toContainText('#5'); const wipRegex = /(wip|\[WIP\])/i; @@ -45,16 +43,16 @@ test.describe('Pull: Toggle WIP', () => { async function setTitle({page}: {page: Page}, title: string) { await page.locator('#issue-title-edit-show').click(); await page.locator('#issue-title-editor input').fill(title); + const loadPromise = page.waitForEvent('load'); await page.getByText('Save').click(); + await loadPromise; } test.beforeEach(async ({page}) => { const response = await page.goto('/user2/repo1/pulls/5'); expect(response?.status()).toBe(200); // Status OK // ensure original title - await page.locator('#issue-title-edit-show').click(); - await page.locator('#issue-title-editor input').fill(prTitle); - await page.getByText('Save').click(); + await setTitle({page}, prTitle); await check_wip({page}, false); }); @@ -69,9 +67,7 @@ test.describe('Pull: Toggle WIP', () => { test('manual edit', async ({page}) => { // manually edit title to another prefix - await page.locator('#issue-title-edit-show').click(); - await page.locator('#issue-title-editor input').fill(`[WIP] ${prTitle}`); - await page.getByText('Save').click(); + await setTitle({page}, `[WIP] ${prTitle}`); await check_wip({page}, true); // remove again await toggle_wip_to({page}, false); @@ -81,9 +77,7 @@ test.describe('Pull: Toggle WIP', () => { test('maximum title length', async ({page}) => { // check maximum title length is handled gracefully const maxLenStr = prTitle + 'a'.repeat(240); - await page.locator('#issue-title-edit-show').click(); - await page.locator('#issue-title-editor input').fill(maxLenStr); - await page.getByText('Save').click(); + await setTitle({page}, maxLenStr); await expect(page.locator('h1')).toContainText(maxLenStr); await check_wip({page}, false); await toggle_wip_to({page}, true);