peezy-tech/jojo
2
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2026-05-12 22:10:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

chore: polish linter error vs. dead code reporting (#11217)

Browse source 
This PR improves and clarifies linter error reporting vs. dead code reporting.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/11217
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: Nils Goroll <nils.goroll@uplex.de>
Co-committed-by: Nils Goroll <nils.goroll@uplex.de>
This commit is contained in:
Nils Goroll 2026-03-20 07:06:09 +01:00 • committed by Gusted
parent 0d879c48ef
commit 6bd8c976b6
2 changed files with 17 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

1
.gitignore vendored
View file

@ -107,6 +107,7 @@ cpu.out
/.air
/.go-licenses
/.cur-deadcode-out
/.deadcode.diff
# Files and folders that were previously generated
/public/assets/img/webpack

20
Makefile
View file

@ -486,11 +486,23 @@ RUN_DEADCODE = $(GO) run $(DEADCODE_PACKAGE) -generated=false -f='{{println .Pat
.PHONY: lint-go
lint-go:
$(GO) run $(GOLANGCI_LINT_PACKAGE) run $(GOLANGCI_LINT_ARGS)
$(GO) run $(ERRORTYPE_PACKAGE) ./...
$(RUN_DEADCODE) > .cur-deadcode-out
@$(DIFF) .deadcode-out .cur-deadcode-out \
$(GO) run $(GOLANGCI_LINT_PACKAGE) run $(GOLANGCI_LINT_ARGS) \
|| (code=$$?; echo "Please run 'make lint-go-fix' and commit the result"; exit $${code})
$(RUN_DEADCODE) > .cur-deadcode-out
@$(DIFF) .deadcode-out .cur-deadcode-out >.deadcode.diff || true
@if grep -qE '^[+][^+]' .deadcode.diff ; then \
cat .deadcode.diff ; \
echo "Looks like you added dead code, please evaluate and remove or use it."; \
echo "If you are sure the dead code should stay around, please run 'make lint-go-fix',"; \
echo "commit the result and explain the reason in the commit message / PR description."; \
exit 1; \
fi
@if grep -qE '^[-][^-]' .deadcode.diff ; then \
cat .deadcode.diff ; \
echo "Looks like you removed dead code. Thank you!"; \
echo "Run 'make lint-go-fix' and commit the result to accept."; \
fi
$(GO) run $(ERRORTYPE_PACKAGE) ./...
.PHONY: lint-go-fix
lint-go-fix: