From 75cfa31af5d6893f39a3fb59f5001d6edad65c82 Mon Sep 17 00:00:00 2001 From: Gusted Date: Fri, 1 May 2026 01:24:32 +0200 Subject: [PATCH] fix: set `repo_id` for migrated attachment (#12357) Was not required until ce0a3767230bf0ed2a16f69fd3eb0afe0dff6168 added extra checks which did require `repo_id` of the attachment to be set correctly. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/12357 Reviewed-by: Mathieu Fenniak --- models/repo/release.go | 1 + models/repo/release_test.go | 3 +++ 2 files changed, 4 insertions(+) diff --git a/models/repo/release.go b/models/repo/release.go index edd628fa0f..8aa447bda8 100644 --- a/models/repo/release.go +++ b/models/repo/release.go @@ -608,6 +608,7 @@ func InsertReleases(ctx context.Context, rels ...*Release) error { if len(rel.Attachments) > 0 { for i := range rel.Attachments { rel.Attachments[i].ReleaseID = rel.ID + rel.Attachments[i].RepoID = rel.RepoID } if _, err := sess.NoAutoTime().Insert(rel.Attachments); err != nil { diff --git a/models/repo/release_test.go b/models/repo/release_test.go index 69f9333589..940de757c7 100644 --- a/models/repo/release_test.go +++ b/models/repo/release_test.go @@ -20,11 +20,14 @@ func TestMigrate_InsertReleases(t *testing.T) { UUID: "a0eebc91-9c0c-4ef7-bb6e-6bb9bd380a12", } r := &Release{ + RepoID: 1001, Attachments: []*Attachment{a}, } err := InsertReleases(db.DefaultContext, r) require.NoError(t, err) + + assert.EqualValues(t, 1001, unittest.AssertExistsAndLoadBean(t, &Attachment{UUID: "a0eebc91-9c0c-4ef7-bb6e-6bb9bd380a12"}).RepoID) } func TestReleaseLoadRepo(t *testing.T) {