From 97844fa8a8dc583dcb6ea3a32af972ab1e1b13eb Mon Sep 17 00:00:00 2001 From: Gusted Date: Tue, 30 Dec 2025 02:23:15 +0100 Subject: [PATCH] fix: load reviewer for pull review dismiss action notifier This was implicitly loaded during the mail notifications notifier. If you disable mail notifications on Forgejo then this will result in the reviewer not being loaded and NPE. --- services/feed/action.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/services/feed/action.go b/services/feed/action.go index a2cd0551a3..483ecbbde5 100644 --- a/services/feed/action.go +++ b/services/feed/action.go @@ -300,6 +300,10 @@ func (*actionNotifier) AutoMergePullRequest(ctx context.Context, doer *user_mode } func (*actionNotifier) NotifyPullRevieweDismiss(ctx context.Context, doer *user_model.User, review *issues_model.Review, comment *issues_model.Comment) { + if err := review.LoadReviewer(ctx); err != nil { + log.Error("LoadReviewer '%d/%d': %v", review.ID, review.ReviewerID, err) + return + } reviewerName := review.Reviewer.Name if len(review.OriginalAuthor) > 0 { reviewerName = review.OriginalAuthor