From f777d93ebd93cc886fb11f036685ca6583454014 Mon Sep 17 00:00:00 2001 From: forgejo-backport-action Date: Thu, 9 Apr 2026 17:57:49 +0200 Subject: [PATCH] [v15.0/forgejo] fix: display runner version on details page (#12063) **Backport:** https://codeberg.org/forgejo/forgejo/pulls/12059 Display the version of Forgejo Runner on the runner's detail page. That is useful for diagnostics. Originally, the version was displayed on the overview page, but removed in https://codeberg.org/forgejo/forgejo/pulls/11516 due to space constraints. It should have been moved to the details page, but that never happened. ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. All work and communication must conform to Forgejo's [AI Agreement](https://codeberg.org/forgejo/governance/src/branch/main/AIAgreement.md). There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Tests for Go changes (can be removed for JavaScript changes) - I added test coverage for Go changes... - [ ] in their respective `*_test.go` for unit tests. - [ ] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I ran... - [x] `make pr-go` before pushing ### Tests for JavaScript changes (can be removed for Go changes) - I added test coverage for JavaScript changes... - [ ] in `web_src/js/*.test.js` if it can be unit tested. - [x] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)). ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [ ] This change will be noticed by a Forgejo user or admin (feature, bug fix, performance, etc.). I suggest to include a release note for this change. - [ ] This change is not visible to a Forgejo user or admin (refactor, dependency upgrade, etc.). I think there is no need to add a release note for this change. *The decision if the pull request will be shown in the release notes is up to the mergers / release team.* The content of the `release-notes/.md` file will serve as the basis for the release notes. If the file does not exist, the title of the pull request will be used instead. Co-authored-by: Andreas Ahlenstorf Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/12063 Reviewed-by: Andreas Ahlenstorf Reviewed-by: Mathieu Fenniak Co-authored-by: forgejo-backport-action Co-committed-by: forgejo-backport-action --- options/locale_next/locale_en-US.json | 1 + templates/shared/actions/runner_details.tmpl | 10 ++++++++++ tests/e2e/runner-management.test.e2e.ts | 12 ++++++++++++ 3 files changed, 23 insertions(+) diff --git a/options/locale_next/locale_en-US.json b/options/locale_next/locale_en-US.json index 94296511be..89e0ce33f5 100644 --- a/options/locale_next/locale_en-US.json +++ b/options/locale_next/locale_en-US.json @@ -447,6 +447,7 @@ "actions.runners.token": "Token", "actions.runners.ephemeral": "Ephemeral", "actions.runners.labels": "Labels", + "actions.runners.version": "Version", "actions.runners.last_online": "Last online time", "actions.runners.list_runners.details_column": "Details", "actions.runners.list_runners.edit_column": "Edit", diff --git a/templates/shared/actions/runner_details.tmpl b/templates/shared/actions/runner_details.tmpl index 7e4cad3b35..f50e96482a 100644 --- a/templates/shared/actions/runner_details.tmpl +++ b/templates/shared/actions/runner_details.tmpl @@ -78,6 +78,16 @@ {{end}} +
+
{{ctx.Locale.Tr "actions.runners.version"}}
+
+ {{if .Runner.Version}} + {{.Runner.Version}} + {{else}} + — + {{end}} +
+
{{ctx.Locale.Tr "actions.runners.description"}}
diff --git a/tests/e2e/runner-management.test.e2e.ts b/tests/e2e/runner-management.test.e2e.ts index cecde7a850..41808f72d1 100644 --- a/tests/e2e/runner-management.test.e2e.ts +++ b/tests/e2e/runner-management.test.e2e.ts @@ -80,6 +80,8 @@ test.describe('Runners of user2', () => { - definition: Offline - term: Ephemeral - definition: "no" + - term: Version + - definition: 12.2.0 - term: Description - definition: A runner for everyone `); @@ -200,6 +202,8 @@ test.describe('Runners of user2', () => { - definition: Offline - term: Ephemeral - definition: "no" + - term: Version + - definition: — - term: Description - definition: Description of runner-46636 `); @@ -370,6 +374,8 @@ test.describe('Global runners', () => { - definition: Offline - term: Ephemeral - definition: "no" + - term: Version + - definition: 12.2.0 - term: Description - definition: A runner for everyone `); @@ -491,6 +497,8 @@ test.describe('Global runners', () => { - definition: Offline - term: Ephemeral - definition: "no" + - term: Version + - definition: — - term: Description - definition: Description of runner-956858 `); @@ -594,6 +602,8 @@ test.describe('Organization runners', () => { - definition: Offline - term: Ephemeral - definition: "no" + - term: Version + - definition: 12.2.0 - term: Description - definition: A runner for everyone `); @@ -722,6 +732,8 @@ test.describe('Repository runners', () => { - definition: Offline - term: Ephemeral - definition: "no" + - term: Version + - definition: 12.2.0 - term: Description - definition: A runner for everyone `);