3 commits

Author	SHA1	Message	Date
TurtleArmy	5b6c702f41	feat(ui): support Pandoc style code blocks (#12099) ... This resolves https://codeberg.org/forgejo/forgejo/issues/11107. Codeberg doesn't support [Pandoc style code blocks](https://pandoc.org/MANUAL.html#extension-fenced_code_attributes), so only the two of these 3 will have syntax highlighting. \`\`\`haskell qsort [] = [] qsort (x:xs) = qsort (filter (< x) xs) ++ [x] ++ qsort (filter (>= x) xs) \`\`\` \`\`\`haskell {.numberLines} qsort [] = [] qsort (x:xs) = qsort (filter (< x) xs) ++ [x] ++ qsort (filter (>= x) xs) \`\`\` \`\`\`{.numberLines .haskell} qsort [] = [] qsort (x:xs) = qsort (filter (< x) xs) ++ [x] ++ qsort (filter (>= x) xs) \`\`\` ```haskell qsort [] = [] qsort (x:xs) = qsort (filter (< x) xs) ++ [x] ++ qsort (filter (>= x) xs) ``` ```haskell {.numberLines} qsort [] = [] qsort (x:xs) = qsort (filter (< x) xs) ++ [x] ++ qsort (filter (>= x) xs) ``` ```{.numberLines .haskell} qsort [] = [] qsort (x:xs) = qsort (filter (< x) xs) ++ [x] ++ qsort (filter (>= x) xs) ``` This PR adds syntax highlighting to the examples with Pandoc style code blocks. It also adds redundant code to explicitly handle the second case with the trailing attribute syntax, which might be unnecessary since it already works, but I think should be fine to leave in. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/12099 Reviewed-by: Ellen Εμίλια Άννα Zscheile <fogti@noreply.codeberg.org> Reviewed-by: Gusted <gusted@noreply.codeberg.org>	2026-05-12 00:53:09 +02:00
Mathieu Fenniak	bc7c8e3c84	fix: markdown rendering panic when code blocks do not have languages (#12325) ... When attempting to render a markdown code block that does not have a language set in it, Forgejo will fail to render and log an error: ``` 2026/04/29 08:47:47 ...markdown/markdown.go:162:func1() [W] Unable to render markdown due to panic in goldmark: runtime error: invalid memory address or nil pointer dereference ``` This is a regression introduced by #12056. ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. All work and communication must conform to Forgejo's [AI Agreement](https://codeberg.org/forgejo/governance/src/branch/main/AIAgreement.md). There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Tests for Go changes - I added test coverage for Go changes... - [x] in their respective `*_test.go` for unit tests. - [ ] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I ran... - [x] `make pr-go` before pushing ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [ ] This change will be noticed by a Forgejo user or admin (feature, bug fix, performance, etc.). I suggest to include a release note for this change. - [x] This change is not visible to a Forgejo user or admin (refactor, dependency upgrade, etc.). I think there is no need to add a release note for this change. - pre-release regression Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/12325 Reviewed-by: Gusted <gusted@noreply.codeberg.org>	2026-04-29 19:49:55 +02:00
TurtleArmy	2b42fdaa26	feat(ui): Fix comma separated attributes in code blocks language preventing syntax-highlighting (#12056) ... Currently, forgejo does not support syntax highlighting code-blocks that have comma separated attributes after the language. This is a pattern sometimes seen in Rust code blocks, with tests like this: \`\`\`rust #[test] fn run_this_test() { /* ... */ } \`\`\` \`\`\`rust,ignore #[test] fn skip_this_test() { /* ... */ } \`\`\` Currently, forgejo only does syntax highlighting in the first case: ```rust #[test] fn run_this_test() { /* ... */ } ``` ```rust,ignore #[test] fn skip_this_test() { /* ... */ } ``` An example of this causing problems can be seen in this commit (5be9c5b7d2) causing the following issue (https://codeberg.org/zesterer/ariadne/issues/188). This PR fixes fixes the second case not getting proper syntax highlighting. Co-authored-by: TurtleArmy <44322335+TurtleArmyMc@users.noreply.github.com> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/12056 Reviewed-by: Gusted <gusted@noreply.codeberg.org> Reviewed-by: Ellen Εμίλια Άννα Zscheile <fogti@noreply.codeberg.org> Co-authored-by: TurtleArmy <turtlearmy@noreply.codeberg.org> Co-committed-by: TurtleArmy <turtlearmy@noreply.codeberg.org>	2026-04-12 18:30:30 +02:00