mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-05-12 22:10:25 +00:00
9b88e77c19
Protect OIDC tokens generated by Forgejo Actions from threats arising when users or repositories are renamed or deleted, freeing their names up for reuse by another user. In this threat environment, relying on the name of users and repositories in validating JWT claims is unsafe because they can change. Adds three new claims to Actions' OIDC tokens: - `actor_id` -- the immutable identifier of the actor who triggered an Action run - `repository_id` -- the immutable identifier of the repository on which the Action is running - `repository_owner_id` -- the immutable identifier of the owner of the repository on which the Action is running Repositories will change their subject (`sub`) OIDC claims to include these immutable identifiers. Existing repositories will not change, in order to maintain compatibility with existing JWT usage. The new format will be applied to new repositories, or can be applied by disabling and enabling the Actions unit. The new format embeds the identifiers: - **Existing repos:** `repo:my-org/my-repo:ref:refs/heads/main` - **New repos:** `repo:my-org-123456/my-repo-456789:ref:refs/heads/main` Fixes #12244. ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. All work and communication must conform to Forgejo's [AI Agreement](https://codeberg.org/forgejo/governance/src/branch/main/AIAgreement.md). There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Tests for Go changes - I added test coverage for Go changes... - [x] in their respective `*_test.go` for unit tests. - [ ] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I ran... - [x] `make pr-go` before pushing ### Documentation - [x] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - New fields will be added to documentation soon. - [ ] I did not document these changes and I do not expect someone else to do it. ### Release notes - [x] This change will be noticed by a Forgejo user or admin (feature, bug fix, performance, etc.). I suggest to include a release note for this change. - [ ] This change is not visible to a Forgejo user or admin (refactor, dependency upgrade, etc.). I think there is no need to add a release note for this change. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/12355 Reviewed-by: Andreas Ahlenstorf <aahlenst@noreply.codeberg.org> |
||
|---|---|---|
| .. | ||
| Test_AddCombinedIndexToIssueUser | ||
| Test_AddConfidentialClientColumnToOAuth2ApplicationTable | ||
| Test_AddForeignKeysAccess | ||
| Test_addForeignKeysActionRunnerToken | ||
| Test_addForeignKeysCollaboration | ||
| Test_addForeignKeysForgejoAuthToken | ||
| Test_addForeignKeysPullRequest1 | ||
| Test_AddForeignKeysStopwatchTrackedTime | ||
| Test_AddHeaderAuthorizationEncryptedColWebhook | ||
| Test_AddIssueResourceIndexTable | ||
| Test_AddPayloadVersionToHookTaskTable | ||
| Test_AddRepoIDForAttachment | ||
| Test_AddUniqueIndexForProjectIssue | ||
| Test_ChangeMavenArtifactConcatenation | ||
| Test_CheckProjectColumnsConsistency | ||
| Test_DeleteOrphanedIssueLabels | ||
| Test_MigrateActionSecretToKeying | ||
| Test_MigrateNormalizedFederatedURI | ||
| Test_MigrateTaskSecretsToKeying | ||
| Test_MigrateTwoFactorToKeying | ||
| Test_MigrateWebhookSecrets | ||
| Test_RemigrateU2FCredentials | ||
| Test_RemoveInvalidLabels | ||
| Test_removeSoftDeleteActionRunnerToken | ||
| Test_RemoveSSHSignaturesFromReleaseNotes | ||
| Test_RepositoryFormat | ||
| Test_setOIDCSubjectFormatLegacy15 | ||
| Test_SetTopicsAsEmptySlice | ||
| Test_StoreWebauthnCredentialIDAsBytes | ||
| Test_UnwrapLDAPSourceCfg | ||
| Test_UpdateBadgeColName | ||
| Test_UpdateOpenMilestoneCounts | ||
| Test_v14ActionsApprovalAndTrustPopulateTableActionUser | ||