mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-05-19 01:06:36 +00:00
0211c1eace
The session cookie has no Max-Age, so it is lost when the browser closes. The password flow compensates via a "Remember me" checkbox issuing an LTA cookie; OAuth2/OIDC sign-in had no such UI. Issuing a regular LTA cookie after an OAuth callback would skip the IdP for LOGIN_REMEMBER_DAYS. Instead, this introduces a separate LongTermAuthorizationSSO purpose: the cookie is opt-in via the existing "Remember me" checkbox, and when presented without a session, autoSignIn redirects through the IdP with OIDC prompt=none for silent re-auth. On login_required / interaction_required / consent_required / account_selection_required we transparently fall back to interactive sign-in. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/12321 Reviewed-by: Mathieu Fenniak <mfenniak@noreply.codeberg.org> Reviewed-by: Gusted <gusted@noreply.codeberg.org>
74 lines
2.4 KiB
Go
74 lines
2.4 KiB
Go
// Copyright 2021 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package oauth2
|
|
|
|
import (
|
|
"net/http"
|
|
"net/url"
|
|
|
|
"github.com/markbates/goth"
|
|
"github.com/markbates/goth/gothic"
|
|
)
|
|
|
|
// Callout redirects request/response pair to authenticate against the provider.
|
|
// prompt, if non-empty, is appended as the OIDC `prompt` parameter.
|
|
func (source *Source) Callout(request *http.Request, response http.ResponseWriter, codeChallengeS256, prompt string) error {
|
|
// not sure if goth is thread safe (?) when using multiple providers
|
|
request.Header.Set(ProviderHeaderKey, source.authSource.Name)
|
|
|
|
extras := url.Values{}
|
|
if codeChallengeS256 != "" {
|
|
extras.Set("code_challenge_method", "S256")
|
|
extras.Set("code_challenge", codeChallengeS256)
|
|
}
|
|
if prompt != "" {
|
|
extras.Set("prompt", prompt)
|
|
}
|
|
var querySuffix string
|
|
if len(extras) > 0 {
|
|
querySuffix = "&" + extras.Encode()
|
|
}
|
|
|
|
// don't use the default gothic begin handler to prevent issues when some error occurs
|
|
// normally the gothic library will write some custom stuff to the response instead of our own nice error page
|
|
// gothic.BeginAuthHandler(response, request)
|
|
|
|
gothRWMutex.RLock()
|
|
defer gothRWMutex.RUnlock()
|
|
|
|
url, err := gothic.GetAuthURL(response, request)
|
|
if err == nil {
|
|
// hacky way to set the code_challenge, but no better way until
|
|
// https://github.com/markbates/goth/issues/516 is resolved
|
|
http.Redirect(response, request, url+querySuffix, http.StatusTemporaryRedirect)
|
|
}
|
|
return err
|
|
}
|
|
|
|
// Callback handles OAuth callback, resolve to a goth user and send back to original url
|
|
// this will trigger a new authentication request, but because we save it in the session we can use that
|
|
func (source *Source) Callback(request *http.Request, response http.ResponseWriter, codeVerifier string) (goth.User, error) {
|
|
// not sure if goth is thread safe (?) when using multiple providers
|
|
request.Header.Set(ProviderHeaderKey, source.authSource.Name)
|
|
|
|
if codeVerifier != "" {
|
|
// hacky way to set the code_verifier...
|
|
// Will be picked up inside CompleteUserAuth: params := req.URL.Query()
|
|
// https://github.com/markbates/goth/pull/474/files
|
|
request = request.Clone(request.Context())
|
|
q := request.URL.Query()
|
|
q.Add("code_verifier", codeVerifier)
|
|
request.URL.RawQuery = q.Encode()
|
|
}
|
|
|
|
gothRWMutex.RLock()
|
|
defer gothRWMutex.RUnlock()
|
|
|
|
user, err := gothic.CompleteUserAuth(response, request)
|
|
if err != nil {
|
|
return user, err
|
|
}
|
|
|
|
return user, nil
|
|
}
|