mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-05-12 22:10:25 +00:00
Previously, when triggering workflows with `workflow_dispatch`, Forgejo only interpreted `on` as boolean `true`. Everything else, including `true`, was treated as `false`. This behaviour does not match the [Forgejo documentation](https://forgejo.org/docs/v13.0/user/actions/reference/#onworkflow_dispatch) that states that `true` and `false` are permitted values. It is also outside the [YAML 1.2 specification of booleans](https://yaml.org/spec/1.2.2/#10212-boolean) that only permits `true` and `false`. After this change, only `true` and `false` have the desired effect. `on` (converted to `true`) is kept for compatibility reasons to give people time to upgrade. This problem only affected users of the Forgejo API, because the UI sent the expected values. Resolves forgejo/forgejo#10070 by fixing the documentation mismatch. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/10089 Reviewed-by: klausfyhn <klausfyhn@noreply.codeberg.org> Reviewed-by: Gusted <gusted@noreply.codeberg.org> Co-authored-by: Andreas Ahlenstorf <andreas@ahlenstorf.ch> Co-committed-by: Andreas Ahlenstorf <andreas@ahlenstorf.ch>
100 lines
4.3 KiB
Go HTML Template
100 lines
4.3 KiB
Go HTML Template
<div class="ui info message tw-flex tw-items-center">
|
|
<span>
|
|
{{ctx.Locale.Tr "actions.workflow.dispatch.trigger_found"}}
|
|
</span>
|
|
<div class="ui dropdown custom tw-ml-4" id="workflow_dispatch_dropdown">
|
|
<button class="ui compact small basic button tw-flex">
|
|
<span class="text">{{ctx.Locale.Tr "actions.workflow.dispatch.run"}}</span>
|
|
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
|
|
</button>
|
|
<div class="menu">
|
|
<div class="message ui form">
|
|
<div class="field">
|
|
<label>{{ctx.Locale.Tr "actions.workflow.dispatch.use_from"}}</label>
|
|
{{template "repo/branch_dropdown" dict
|
|
"root" (dict
|
|
"IsViewBranch" true
|
|
"BranchName" .Repo.BranchName
|
|
"CommitID" .Repo.CommitID
|
|
"RepoLink" .Repo.RepoLink
|
|
"Repository" .Repo.Repository
|
|
)
|
|
"disableCreateBranch" true
|
|
"branchForm" "branch-dropdown-form"
|
|
"setAction" false
|
|
"submitForm" false
|
|
}}
|
|
</div>
|
|
|
|
<form method="post" action="{{.Repo.RepoLink}}/actions/manual" id="branch-dropdown-form">
|
|
{{range $i, $key := .CurWorkflowDispatchInputKeys}}
|
|
{{$val := index $.CurWorkflowDispatch.Inputs $key}}
|
|
<div class="{{if $val.Required}}required {{end}}field">
|
|
{{if eq $val.Type "boolean"}}
|
|
<div class="ui checkbox">
|
|
<label><strong>{{if $val.Description}}{{$val.Description}}{{else}}{{$key}}{{end}}</strong></label>
|
|
{{/* These two inputs need to stay in exactly this order (checkbox first, hidden second) or boolean fields won't work correctly! */}}
|
|
<input type="checkbox" name="inputs[{{$key}}]" value="true" {{if eq $val.Default "true"}}checked{{end}}>
|
|
<input type="hidden" name="inputs[{{$key}}]" value="false" autocomplete="off">
|
|
</div>
|
|
{{else}}
|
|
<label>{{if $val.Description}}{{$val.Description}}{{else}}{{$key}}{{end}}</label>
|
|
{{if eq $val.Type "number"}}
|
|
<input {{if $val.Required}}required{{end}} type="number" name="inputs[{{$key}}]" {{if $val.Default}}value="{{$val.Default}}"{{end}}>
|
|
{{else if eq $val.Type "string"}}
|
|
<input {{if $val.Required}}required{{end}} type="text" name="inputs[{{$key}}]" {{if $val.Default}}value="{{$val.Default}}"{{end}}>
|
|
{{else if eq $val.Type "choice"}}
|
|
<div class="ui selection dropdown">
|
|
<input name="inputs[{{$key}}]" type="hidden" value="{{$val.Default}}">
|
|
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
|
|
<div class="text"></div>
|
|
<div class="menu">
|
|
{{range $opt := $val.Options}}
|
|
<div data-value="{{$opt}}" class="{{if eq $val.Default $opt}}active selected {{end}}item">{{$opt}}</div>
|
|
{{end}}
|
|
</div>
|
|
</div>
|
|
{{else}}
|
|
<strong>{{ctx.Locale.Tr "actions.workflow.dispatch.invalid_input_type" $val.Type}}</strong>
|
|
{{end}}
|
|
{{end}}
|
|
</div>
|
|
{{end}}
|
|
|
|
{{if .WarnDispatchInputsLimit}}
|
|
<div class="text yellow tw-mb-4">
|
|
{{svg "octicon-alert"}} {{ctx.Locale.Tr "actions.workflow.dispatch.warn_input_limit" .DispatchInputsLimit}}
|
|
</div>
|
|
{{end}}
|
|
|
|
<input type="hidden" name="ref" value="{{if $.Repo.BranchName}}{{$.Repo.BranchName}}{{else}}{{$.Repo.Repository.DefaultBranch}}{{end}}">
|
|
<input type="hidden" name="workflow" value="{{$.CurWorkflow}}">
|
|
<input type="hidden" name="actor" value="{{$.CurActor}}">
|
|
<input type="hidden" name="status" value="{{$.CurStatus}}">
|
|
<button type="submit" id="workflow-dispatch-submit" class="ui primary small compact button">{{ctx.Locale.Tr "actions.workflow.dispatch.run"}}</button>
|
|
</form>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
<script>
|
|
window.addEventListener('load', () => {
|
|
const dropdown = $('#workflow_dispatch_dropdown');
|
|
const menu = dropdown.find('> .menu');
|
|
$(document.body).on('click', (ev) => {
|
|
if (!dropdown[0].contains(ev.target) && menu.hasClass('visible')) {
|
|
menu.transition({ animation: 'slide down out', duration: 200, queue: false });
|
|
}
|
|
});
|
|
dropdown.on('click', (ev) => {
|
|
const inMenu = $(ev.target).closest(menu).length !== 0;
|
|
if (inMenu) return;
|
|
ev.stopPropagation();
|
|
if (menu.hasClass('visible')) {
|
|
menu.transition({ animation: 'slide down out', duration: 200, queue: false });
|
|
} else {
|
|
menu.transition({ animation: 'slide down in', duration: 200, queue: true });
|
|
}
|
|
});
|
|
});
|
|
</script>
|
|
</div>
|