peezy-tech/jojo
2
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2026-05-13 06:20:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3
jojo/services/pull
History
Exact
forgejo-backport-action 4b8a01c879 [v12.0/forgejo] fix: use correct commit when fetching patch view for review comments (#9374) 
**Backport:** https://codeberg.org/forgejo/forgejo/pulls/9264

This is effectively a clean revert of e7a77d32cc, which for some reason broke this logic.

Yes, always having the latest code shown in the diff is nice, but doing this mismatches the commitID and the line number the comment is being posted on, which very easily and frequently leads to reviews that show a completely nonsensical patch above them, cause the code it's referring too shifted by several lines since the time the review was started and the time it was posted.

Co-authored-by: BtbN <btbn@btbn.de>
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/9374
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: forgejo-backport-action <forgejo-backport-action@noreply.codeberg.org>
Co-committed-by: forgejo-backport-action <forgejo-backport-action@noreply.codeberg.org>
2025-09-22 03:28:05 +02:00
..
check.go fix: do not ignore automerge while a PR is checking for conflicts (#8189) 2025-06-17 10:58:07 +02:00
check_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
comment.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
commit_status.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
commit_status_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
edits.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
lfs.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
main_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
merge.go [v12.0/forgejo] fix: prevent pull requests from being merged multiple times (#8862) 2025-08-11 23:08:46 +02:00
merge_ff_only.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
merge_merge.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
merge_prepare.go [v12.0/forgejo] fix: rebase and fast forward merge breaks commit signatures (#8624) 2025-07-23 10:55:17 +02:00
merge_rebase.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
merge_squash.go [gitea] Always use an empty line to separate the commit message and trailer (#8041) 2025-06-02 22:10:59 +02:00
merge_test.go [v12.0/forgejo] fix: prevent pull requests from being merged multiple times (#8862) 2025-08-11 23:08:46 +02:00
patch.go feat: improved performances when checking for conflicts on pull requests (#7727) 2025-05-16 12:40:38 +00:00
patch_test.go feat: improved performances when checking for conflicts on pull requests (#7727) 2025-05-16 12:40:38 +00:00
patch_unmerged.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
pull.go feat: improved performances when checking for conflicts on pull requests (#7727) 2025-05-16 12:40:38 +00:00
pull_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
review.go [v12.0/forgejo] fix: use correct commit when fetching patch view for review comments (#9374) 2025-09-22 03:28:05 +02:00
review_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
temp_repo.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
update.go chore(cleanup): replaces unnecessary calls to formatting functions by non-formatting equivalents (#7994) 2025-05-29 17:34:29 +02:00
update_rebase.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00