mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-05-17 16:26:34 +00:00
b5e91db9c9
**Backport:** https://codeberg.org/forgejo/forgejo/pulls/10297 The package cleanup routine checks every container version for whether it is referenced by a multi-platform manifest, which appears to be a performance problem indicated by CPU profiling collected in #9358 on SQLite systems. This PR removes that check completely, which isn't necessary since #4698 added a much more performant mass-cleanup of these dangling platform versions. May fix #9358 completely, but it leaves fundamental scalability concerns with SQLite due to long-running transactions. The transactions will be shorter with this change. Requires end-user testing to confirm if sufficiently fixed. ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Tests - I added test coverage for Go changes... - [x] in their respective `*_test.go` for unit tests. - [x] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I added test coverage for JavaScript changes... - [ ] in `web_src/js/*.test.js` if it can be unit tested. - [ ] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)). ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [ ] I do not want this change to show in the release notes. - [x] I want the title to show in the release notes with a link to this pull request. - [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title. <!--start release-notes-assistant--> ## Release notes <!--URL:https://codeberg.org/forgejo/forgejo--> - Bug fixes - [PR](https://codeberg.org/forgejo/forgejo/pulls/10334): <!--number 10334 --><!--line 0 --><!--description Zml4OiByZWR1Y2UgcnVudGltZSBvZiBjb250YWluZXIgY2xlYW51cCBieSByZWx5aW5nIG9uIG1hc3MgZGlnZXN0IGNsZWFudXA=-->fix: reduce runtime of container cleanup by relying on mass digest cleanup<!--description--> <!--end release-notes-assistant--> Co-authored-by: Mathieu Fenniak <mathieu@fenniak.net> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/10334 Reviewed-by: Mathieu Fenniak <mfenniak@noreply.codeberg.org> Co-authored-by: forgejo-backport-action <forgejo-backport-action@noreply.codeberg.org> Co-committed-by: forgejo-backport-action <forgejo-backport-action@noreply.codeberg.org> |
||
|---|---|---|
| .. | ||
| TestActionVariablesModification | ||
| TestAdminDeleteUser | ||
| TestAdminModerationViewReports | ||
| TestAPIRemoveIssueLabelByName | ||
| TestBlockActions | ||
| TestBlockedNotifications | ||
| TestCommitRefComment | ||
| TestFeed | ||
| TestForcePushCommitStatus | ||
| TestGetContentHistory | ||
| TestIssueCommentChangeProject | ||
| TestPackageContainerCleanup | ||
| TestPullCombinedReviewRequest | ||
| TestPullMirrorRedactCredentials | ||
| TestPullRequestReplyMail | ||
| TestRunnerModification | ||
| TestSystemCommentRoles | ||
| TestUserPasswordResetOAuth2 | ||
| TestXSSReviewDismissed | ||