mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-05-12 22:10:25 +00:00
- fix: prevent git write to wiki repo from unauthorized user via git HTTP - fix: prevent LFS authorization token from being used for read/write access after user's access is restricted from Forgejo - fix: prevent scoped API access (OAuth tokens, Access tokens) from accessing resources beyond their permitted scope via non-API endpoints (e.g. /user/repo/raw/...) - fix: implementing missing OAuth validation checks, improve protections against race conditions - fix: prevent OAuth redirect URI spoofing via non-ascii case collision - fix: strengthen Actions Artifact V4 signature algorithm against spoofing attacks <!--start release-notes-assistant--> ## Release notes <!--URL:https://codeberg.org/forgejo/forgejo--> - Security bug fixes - [PR](https://codeberg.org/forgejo/forgejo/pulls/12493): <!--number 12493 --><!--line 0 --><!--description MjAyNi0wNS0xMiBzZWN1cml0eSBwYXRjaGVz-->2026-05-12 security patches<!--description--> <!--end release-notes-assistant--> Co-authored-by: Derzsi Dániel <daniel@tohka.us> Co-authored-by: jvoisin <julien.voisin@dustri.org> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/12493
181 lines
6 KiB
Go
181 lines
6 KiB
Go
// Copyright 2025 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package lfs
|
|
|
|
import (
|
|
"fmt"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
perm_model "forgejo.org/models/perm"
|
|
repo_model "forgejo.org/models/repo"
|
|
"forgejo.org/models/unittest"
|
|
"forgejo.org/modules/setting"
|
|
"forgejo.org/services/contexttest"
|
|
|
|
"github.com/golang-jwt/jwt/v5"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestMain(m *testing.M) {
|
|
unittest.MainTest(m)
|
|
}
|
|
|
|
type authTokenOptions struct {
|
|
Op string
|
|
UserID int64
|
|
RepoID int64
|
|
}
|
|
|
|
func getLFSAuthTokenWithBearer(opts authTokenOptions) (string, error) {
|
|
now := time.Now()
|
|
claims := Claims{
|
|
RegisteredClaims: jwt.RegisteredClaims{
|
|
ExpiresAt: jwt.NewNumericDate(now.Add(setting.LFS.HTTPAuthExpiry)),
|
|
NotBefore: jwt.NewNumericDate(now),
|
|
},
|
|
RepoID: opts.RepoID,
|
|
Op: opts.Op,
|
|
UserID: opts.UserID,
|
|
}
|
|
|
|
// Sign and get the complete encoded token as a string using the secret
|
|
tokenString, err := setting.LFS.SigningKey.JWT(claims)
|
|
if err != nil {
|
|
return "", fmt.Errorf("failed to sign LFS JWT token: %w", err)
|
|
}
|
|
return "Bearer " + tokenString, nil
|
|
}
|
|
|
|
func testAuthenticate(t *testing.T, cfg string) {
|
|
require.NoError(t, unittest.PrepareTestDatabase())
|
|
var err error
|
|
setting.CfgProvider, err = setting.NewConfigProviderFromData(cfg)
|
|
require.NoError(t, err, "Config")
|
|
setting.LoadCommonSettings()
|
|
assert.True(t, setting.LFS.StartServer, "LFS_START_SERVER = true")
|
|
assert.NotNil(t, setting.LFS.SigningKey, "SigningKey initialized")
|
|
repo1 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
|
|
|
|
token2, _ := getLFSAuthTokenWithBearer(authTokenOptions{Op: "download", UserID: 2, RepoID: 1})
|
|
_, token2, _ = strings.Cut(token2, " ")
|
|
ctx, _ := contexttest.MockContext(t, "/")
|
|
|
|
t.Run("handleLFSToken", func(t *testing.T) {
|
|
u, err := handleLFSToken(ctx, "", repo1, perm_model.AccessModeRead)
|
|
require.Error(t, err)
|
|
assert.Nil(t, u)
|
|
|
|
u, err = handleLFSToken(ctx, "invalid", repo1, perm_model.AccessModeRead)
|
|
require.Error(t, err)
|
|
assert.Nil(t, u)
|
|
|
|
u, err = handleLFSToken(ctx, token2, repo1, perm_model.AccessModeRead)
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 2, u.ID)
|
|
})
|
|
|
|
t.Run("handleLFSToken nonexistent user", func(t *testing.T) {
|
|
tokenMissing, _ := getLFSAuthTokenWithBearer(authTokenOptions{Op: "download", UserID: 999, RepoID: 1})
|
|
_, tokenMissing, _ = strings.Cut(tokenMissing, " ")
|
|
|
|
u, err := handleLFSToken(ctx, tokenMissing, repo1, perm_model.AccessModeRead)
|
|
require.Error(t, err)
|
|
assert.Contains(t, err.Error(), "user does not exist")
|
|
assert.Nil(t, u)
|
|
})
|
|
|
|
t.Run("handleLFSToken nonexistent repo", func(t *testing.T) {
|
|
tokenBadRepo, _ := getLFSAuthTokenWithBearer(authTokenOptions{Op: "download", UserID: 2, RepoID: 999})
|
|
_, tokenBadRepo, _ = strings.Cut(tokenBadRepo, " ")
|
|
badRepo := &repo_model.Repository{ID: 999}
|
|
|
|
u, err := handleLFSToken(ctx, tokenBadRepo, badRepo, perm_model.AccessModeRead)
|
|
require.Error(t, err)
|
|
assert.Nil(t, u)
|
|
})
|
|
|
|
t.Run("handleLFSToken blocked user", func(t *testing.T) {
|
|
tokenBlocked, _ := getLFSAuthTokenWithBearer(authTokenOptions{Op: "download", UserID: 37, RepoID: 1})
|
|
_, tokenBlocked, _ = strings.Cut(tokenBlocked, " ")
|
|
|
|
u, err := handleLFSToken(ctx, tokenBlocked, repo1, perm_model.AccessModeRead)
|
|
require.Error(t, err)
|
|
assert.Contains(t, err.Error(), "user access is blocked")
|
|
assert.Nil(t, u)
|
|
})
|
|
|
|
t.Run("handleLFSToken no repo access", func(t *testing.T) {
|
|
repo2 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 2})
|
|
tokenNoAccess, _ := getLFSAuthTokenWithBearer(authTokenOptions{Op: "download", UserID: 10, RepoID: 2})
|
|
_, tokenNoAccess, _ = strings.Cut(tokenNoAccess, " ")
|
|
|
|
u, err := handleLFSToken(ctx, tokenNoAccess, repo2, perm_model.AccessModeRead)
|
|
require.Error(t, err)
|
|
assert.Contains(t, err.Error(), "does not have access to the repository")
|
|
assert.Nil(t, u)
|
|
})
|
|
|
|
t.Run("handleLFSToken upload write access allowed", func(t *testing.T) {
|
|
tokenUploadRW, _ := getLFSAuthTokenWithBearer(authTokenOptions{Op: "upload", UserID: 2, RepoID: 1})
|
|
_, tokenUploadRW, _ = strings.Cut(tokenUploadRW, " ")
|
|
|
|
u, err := handleLFSToken(ctx, tokenUploadRW, repo1, perm_model.AccessModeWrite)
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 2, u.ID)
|
|
})
|
|
|
|
t.Run("handleLFSToken upload read-only access denied", func(t *testing.T) {
|
|
tokenUploadRO, _ := getLFSAuthTokenWithBearer(authTokenOptions{Op: "upload", UserID: 10, RepoID: 1})
|
|
_, tokenUploadRO, _ = strings.Cut(tokenUploadRO, " ")
|
|
|
|
u, err := handleLFSToken(ctx, tokenUploadRO, repo1, perm_model.AccessModeWrite)
|
|
require.Error(t, err)
|
|
assert.Contains(t, err.Error(), "does not have access to the repository")
|
|
assert.Nil(t, u)
|
|
})
|
|
|
|
t.Run("handleLFSToken download read-only access allowed", func(t *testing.T) {
|
|
tokenDownloadRO, _ := getLFSAuthTokenWithBearer(authTokenOptions{Op: "download", UserID: 10, RepoID: 1})
|
|
_, tokenDownloadRO, _ = strings.Cut(tokenDownloadRO, " ")
|
|
|
|
u, err := handleLFSToken(ctx, tokenDownloadRO, repo1, perm_model.AccessModeRead)
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 10, u.ID)
|
|
})
|
|
|
|
t.Run("authenticate", func(t *testing.T) {
|
|
const prefixBearer = "Bearer "
|
|
assert.False(t, authenticate(ctx, repo1, "", true, false))
|
|
assert.False(t, authenticate(ctx, repo1, prefixBearer+"invalid", true, false))
|
|
assert.True(t, authenticate(ctx, repo1, prefixBearer+token2, true, false))
|
|
})
|
|
}
|
|
|
|
type namedCfg struct {
|
|
name, cfg string
|
|
}
|
|
|
|
var iniCommon = `[security]
|
|
INSTALL_LOCK = true
|
|
INTERNAL_TOKEN = ForgejoForgejoForgejoForgejoForgejoForgejo_ # don't use in prod
|
|
[oauth2]
|
|
JWT_SECRET = ForgejoForgejoForgejoForgejoForgejoForgejo_ # don't use in prod
|
|
[server]
|
|
LFS_START_SERVER = true
|
|
`
|
|
|
|
var cfgVariants = []namedCfg{
|
|
{name: "HS256_default", cfg: `LFS_JWT_SECRET = ForgejoForgejoForgejoForgejoForgejoForgejo_`},
|
|
{name: "RS256", cfg: `LFS_JWT_SIGNING_ALGORITHM = RS256`},
|
|
}
|
|
|
|
func TestAuthenticate(t *testing.T) {
|
|
for _, v := range cfgVariants {
|
|
cfg := iniCommon + v.cfg
|
|
t.Run(v.name, func(t *testing.T) { testAuthenticate(t, cfg) })
|
|
}
|
|
}
|