mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-05-12 22:10:25 +00:00
861272b0e9
As discussed on matrix, on my NixOS machine and in a Ubuntu distrobox container these tests were failing, as the byte length of the response was different:
```
api_repo_archive_test.go:43:
Error Trace: /home/vdx/workspace/personal/forgejo/tests/integration/api_repo_archive_test.go:43
Error: "[31 139 8 0 0 0 0 0 0 3 237 212 177 106 195 48 16 6 224 155 253 20 134 238 237 201 146 78 237 208 161 144 140 93 250 2 193 178 165 52 16 71 70 113 32 143 95 26 111 134 180 29 18 135 146 255 91 14 36 129 164 59 157 250 250 184 90 111 147 175 183 171 207 80 183 33 211 229 49 51 139 200 41 50 243 52 50 139 33 165 89 180 21 167 156 35 102 101 172 86 180 166 25 28 246 67 157 137 57 167 52 252 180 238 183 249 233 229 254 9 91 149 77 234 186 176 27 94 197 70 229 99 229 124 163 125 116 28 197 136 117 98 159 69 219 32 194 47 38 180 190 241 166 45 110 125 102 184 156 28 250 164 158 174 155 209 239 126 112 206 158 239 127 230 105 255 87 170 210 100 105 6 119 222 255 99 253 63 150 111 139 247 229 99 215 94 101 143 241 255 55 231 235 175 101 90 127 109 88 209 44 73 188 243 250 63 148 167 23 80 20 139 176 111 242 166 31 54 105 87 198 148 199 225 91 159 14 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 232 15 190 0 14 221 99 58 0 40 0 0]" should have 266 item(s), but has 264
```
Instead of comparing the byte length of the gzipped archive, it's is probably an improvement to check the list of directories and files in the archive instead. The content of these files could be checked as well, as they are relatively small, but in general it might not always be feasible.
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/10161
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: Gabor Pihaj <gabor.pihaj@gmail.com>
Co-committed-by: Gabor Pihaj <gabor.pihaj@gmail.com>
136 lines
5.2 KiB
Go
136 lines
5.2 KiB
Go
// Copyright 2021 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package integration
|
|
|
|
import (
|
|
"archive/tar"
|
|
"bytes"
|
|
"compress/gzip"
|
|
"fmt"
|
|
"io"
|
|
"net/http"
|
|
"net/url"
|
|
"regexp"
|
|
"testing"
|
|
|
|
auth_model "forgejo.org/models/auth"
|
|
repo_model "forgejo.org/models/repo"
|
|
"forgejo.org/models/unittest"
|
|
user_model "forgejo.org/models/user"
|
|
"forgejo.org/tests"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestAPIDownloadArchive(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
|
|
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
|
|
user2 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
|
session := loginUser(t, user2.LowerName)
|
|
token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeReadRepository)
|
|
|
|
link, _ := url.Parse(fmt.Sprintf("/api/v1/repos/%s/%s/archive/master.zip", user2.Name, repo.Name))
|
|
resp := MakeRequest(t, NewRequest(t, "GET", link.String()).AddTokenAuth(token), http.StatusOK)
|
|
bs, err := io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
assert.Len(t, bs, 320)
|
|
assert.Equal(t, "application/zip", resp.Header().Get("Content-Type"))
|
|
|
|
link, _ = url.Parse(fmt.Sprintf("/api/v1/repos/%s/%s/archive/master.tar.gz", user2.Name, repo.Name))
|
|
resp = MakeRequest(t, NewRequest(t, "GET", link.String()).AddTokenAuth(token), http.StatusOK)
|
|
bs, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
fileNames, err := fileNamesFromTarGzip(bs)
|
|
require.NoError(t, err)
|
|
assert.ElementsMatch(t, fileNames, []string{"repo1/", "repo1/README.md"})
|
|
assert.Equal(t, "application/gzip", resp.Header().Get("Content-Type"))
|
|
|
|
// Must return a link to a commit ID as the "immutable" archive link
|
|
linkHeaderRe := regexp.MustCompile(`<(?P<url>https?://.*/api/v1/repos/user2/repo1/archive/[a-f0-9]+\.tar\.gz.*)>; rel="immutable"`)
|
|
m := linkHeaderRe.FindStringSubmatch(resp.Header().Get("Link"))
|
|
assert.NotEmpty(t, m[1])
|
|
resp = MakeRequest(t, NewRequest(t, "GET", m[1]).AddTokenAuth(token), http.StatusOK)
|
|
bs2, err := io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
// The locked URL should give the same bytes as the non-locked one
|
|
assert.Equal(t, bs, bs2)
|
|
|
|
link, _ = url.Parse(fmt.Sprintf("/api/v1/repos/%s/%s/archive/master.bundle", user2.Name, repo.Name))
|
|
resp = MakeRequest(t, NewRequest(t, "GET", link.String()).AddTokenAuth(token), http.StatusOK)
|
|
bs, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
assert.Len(t, bs, 382)
|
|
assert.Equal(t, "application/octet-stream", resp.Header().Get("Content-Type"))
|
|
|
|
link, _ = url.Parse(fmt.Sprintf("/api/v1/repos/%s/%s/archive/master", user2.Name, repo.Name))
|
|
MakeRequest(t, NewRequest(t, "GET", link.String()).AddTokenAuth(token), http.StatusBadRequest)
|
|
}
|
|
|
|
func TestAPIDownloadArchive2(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
|
|
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
|
|
user2 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
|
session := loginUser(t, user2.LowerName)
|
|
token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeReadRepository)
|
|
|
|
link, _ := url.Parse(fmt.Sprintf("/api/v1/repos/%s/%s/zipball/master", user2.Name, repo.Name))
|
|
resp := MakeRequest(t, NewRequest(t, "GET", link.String()).AddTokenAuth(token), http.StatusOK)
|
|
bs, err := io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
assert.Len(t, bs, 320)
|
|
|
|
link, _ = url.Parse(fmt.Sprintf("/api/v1/repos/%s/%s/tarball/master", user2.Name, repo.Name))
|
|
resp = MakeRequest(t, NewRequest(t, "GET", link.String()).AddTokenAuth(token), http.StatusOK)
|
|
bs, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
fileNames, err := fileNamesFromTarGzip(bs)
|
|
require.NoError(t, err)
|
|
assert.ElementsMatch(t, fileNames, []string{"repo1/", "repo1/README.md"})
|
|
|
|
// Must return a link to a commit ID as the "immutable" archive link
|
|
linkHeaderRe := regexp.MustCompile(`^<(https?://.*/api/v1/repos/user2/repo1/archive/[a-f0-9]+\.tar\.gz.*)>; rel="immutable"$`)
|
|
m := linkHeaderRe.FindStringSubmatch(resp.Header().Get("Link"))
|
|
assert.NotEmpty(t, m[1])
|
|
resp = MakeRequest(t, NewRequest(t, "GET", m[1]).AddTokenAuth(token), http.StatusOK)
|
|
bs2, err := io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
// The locked URL should give the same bytes as the non-locked one
|
|
assert.Equal(t, bs, bs2)
|
|
|
|
link, _ = url.Parse(fmt.Sprintf("/api/v1/repos/%s/%s/bundle/master", user2.Name, repo.Name))
|
|
resp = MakeRequest(t, NewRequest(t, "GET", link.String()).AddTokenAuth(token), http.StatusOK)
|
|
bs, err = io.ReadAll(resp.Body)
|
|
require.NoError(t, err)
|
|
assert.Len(t, bs, 382)
|
|
|
|
link, _ = url.Parse(fmt.Sprintf("/api/v1/repos/%s/%s/archive/master", user2.Name, repo.Name))
|
|
MakeRequest(t, NewRequest(t, "GET", link.String()).AddTokenAuth(token), http.StatusBadRequest)
|
|
}
|
|
|
|
func fileNamesFromTarGzip(gzippedTar []byte) ([]string, error) {
|
|
archive, err := gzip.NewReader(bytes.NewReader(gzippedTar))
|
|
if err != nil {
|
|
return []string{}, err
|
|
}
|
|
|
|
files := []string{}
|
|
reader := tar.NewReader(archive)
|
|
for {
|
|
header, err := reader.Next()
|
|
if err == io.EOF {
|
|
return files, nil
|
|
}
|
|
if err != nil {
|
|
return []string{}, err
|
|
}
|
|
|
|
// list of type flags can be found at https://www.gnu.org/software/tar/manual/html_node/Standard.html
|
|
if byte('0') <= header.Typeflag && header.Typeflag <= byte('7') {
|
|
files = append(files, header.Name)
|
|
}
|
|
}
|
|
}
|