peezy-tech/jojo
2
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2026-05-12 22:10:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
jojo/models/repo
History
Mathieu Fenniak a9452d11d0 fix: possible cause of invalid issue counts; cache invalidation occurs before a active transaction is committed (#10130) 
Although #9922 was deployed to Codeberg, it was reported on Matrix that a user observed a `-1` pull request count.

@Gusted checked and verified that the stats stored in redis appeared incorrect, and that no errors occurred on Codeberg that included the repo ID (eg. deadlocks, SQL queries).
```
127.0.0.1:6379> GET Repo:CountPulls:924266
"1"
127.0.0.1:6379> GET Repo:CountPullsClosed:924266
"2"
```

One possible cause is that when `UpdateRepoIssueNumbers` is invoked and invalidates the cache key for the repository, it is currently in a transaction; the next request for that cached count could be computed before the transaction is committed and the update is visible.  It's been verified that `UpdateRepoIssueNumbers` is called within a transaction in most interactions (I put a panic in it if `db.InTransaction(ctx)`, and most related tests failed).

This PR fixes that hole by performing the cache invalidation in an `AfterTx()` hook which is invoked after the transaction is committed to the database.

(Another possible cause is documented in #10127)

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/10130
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: Mathieu Fenniak <mathieu@fenniak.net>
Co-committed-by: Mathieu Fenniak <mathieu@fenniak.net>
2025-11-17 01:07:29 +01:00
..
TestGetUserForkLax fix: reduce deadlocks merging PRs by using caching for repo issue count stats (#9922) 2025-10-31 23:50:05 +01:00
TestGetUserForkLaxWithTwoChoices fix: reduce deadlocks merging PRs by using caching for repo issue count stats (#9922) 2025-10-31 23:50:05 +01:00
TestSearchRepositoryIDsByCondition fix: reduce deadlocks merging PRs by using caching for repo issue count stats (#9922) 2025-10-31 23:50:05 +01:00
archive_download_count.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
archive_download_count_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
archiver.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
attachment.go fix: allow instance API URLs in release assets (#7644) 2025-06-09 10:01:59 +02:00
attachment_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
avatar.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
collaboration.go feat: add foreign keys to table collaboration (#9724) 2025-10-18 02:50:50 +02:00
collaboration_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
following_repo.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
following_repo_test.go chore(cleanup): replaces unnecessary calls to formatting functions by non-formatting equivalents (#7994) 2025-05-29 17:34:29 +02:00
fork.go feat: allow PRs between common forks of the same base repository (#9045) 2025-10-01 04:58:12 +02:00
fork_test.go feat: allow PRs between common forks of the same base repository (#9045) 2025-10-01 04:58:12 +02:00
git.go feat: introduce global merge message templates (#8347) 2025-07-12 16:00:42 +02:00
issue.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
language_stats.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
language_stats_test.go chore: remove usages of sort.Sort (#6689) 2025-01-26 13:30:00 +00:00
main_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
mirror.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
moderation.go feat: Admin interface for abuse reports (#7905) 2025-07-23 00:20:15 +02:00
moderation_test.go feat: Admin interface for abuse reports (#7905) 2025-07-23 00:20:15 +02:00
pushmirror.go feat: cache derived keys for faster keying (#10114) 2025-11-16 14:29:14 +01:00
pushmirror_test.go feat: add configuration to only push mirror selected branches (#7823) 2025-07-12 00:39:35 +02:00
redirect.go fix: do permission check for repository redirect 2025-08-30 09:37:34 +02:00
redirect_test.go fix: do permission check for repository redirect 2025-08-30 09:37:34 +02:00
release.go feat: make upload URL compatible with GitHub API (#9285) 2025-09-15 15:53:35 +02:00
release_list.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
release_list_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
release_test.go feat: add tag label to commit list view (#8759) 2025-08-06 14:47:51 +02:00
repo.go fix: possible cause of invalid issue counts; cache invalidation occurs before a active transaction is committed (#10130) 2025-11-17 01:07:29 +01:00
repo_flags.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
repo_flags_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
repo_indexer.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
repo_list.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
repo_list_test.go chore: merge tests.AddFixtures and unittest.OverrideFixtures (#7648) 2025-04-25 09:14:33 +00:00
repo_repository.go fix: assorted ActivityPub code only refactors (#8708) 2025-07-28 15:17:29 +02:00
repo_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
repo_unit.go fix: a corrupted Forgejo Actions scheduled workflow is disabled (#8942) 2025-08-18 22:45:10 +02:00
repo_unit_test.go fix: corrupted wiki unit default permission (#8234 follow-up) (#8258) 2025-07-07 18:04:00 +02:00
search.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
star.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
star_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
topic.go chore(api): update swagger method descripitons (#8728) 2025-07-30 18:08:28 +02:00
topic_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
update.go chore: remove redundant code (#9378) 2025-09-22 09:18:19 +02:00
update_test.go chore: remove redundant code (#9378) 2025-09-22 09:18:19 +02:00
upload.go feat: Drag and drop nested directories (#6687) 2025-10-03 00:16:40 +02:00
user_repo.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
user_repo_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
watch.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
watch_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
wiki.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
wiki_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00