mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-05-13 14:30:25 +00:00
Adds a user interface for creating repo-specific access tokens (#11311). When the new option "Specific repositories" is selected, a search option appears. Each repository in the search result has an "Add" button to include it on the access token, and once included, a repository can be removed with the "Remove" button. This is a JS-free form. ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Tests for Go changes (can be removed for JavaScript changes) - I added test coverage for Go changes... - [x] in their respective `*_test.go` for unit tests. - [ ] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I ran... - [x] `make pr-go` before pushing ### Tests for JavaScript changes - I added test coverage for JavaScript changes... - [ ] in `web_src/js/*.test.js` if it can be unit tested. - [x] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/ README.md#end-to-end-tests)). - Technically there are no "JavaScript changes" in this PR, but e2e tests were added for browser interaction testing. ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - TODO: planning to create documentation in https://forgejo.org/docs/next/user/token-scope/; there is none for public only tokens but I think this seems like a good place to add both. - [ ] I did not document these changes and I do not expect someone else to do it. ### Release notes - [x] This change will be noticed by a Forgejo user or admin (feature, bug fix, performance, etc.). I suggest to include a release note for this change. - [ ] This change is not visible to a Forgejo user or admin (refactor, dependency upgrade, etc.). I think there is no need to add a release note for this change. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/11696 Reviewed-by: Andreas Ahlenstorf <aahlenst@noreply.codeberg.org> Co-authored-by: Mathieu Fenniak <mathieu@fenniak.net> Co-committed-by: Mathieu Fenniak <mathieu@fenniak.net>
115 lines
2.7 KiB
Go
115 lines
2.7 KiB
Go
// Copyright 2018 The Gogs Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package forms
|
|
|
|
import (
|
|
"strconv"
|
|
"testing"
|
|
|
|
auth_model "forgejo.org/models/auth"
|
|
"forgejo.org/modules/setting"
|
|
"forgejo.org/modules/test"
|
|
|
|
"github.com/gobwas/glob"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestRegisterForm_IsDomainAllowed_Empty(t *testing.T) {
|
|
defer test.MockVariableValue(&setting.Service.EmailDomainAllowList, nil)()
|
|
|
|
form := RegisterForm{}
|
|
|
|
emailValid, ok := form.IsEmailDomainAllowed()
|
|
assert.False(t, emailValid)
|
|
assert.False(t, ok)
|
|
}
|
|
|
|
func TestRegisterForm_IsDomainAllowed_InvalidEmail(t *testing.T) {
|
|
defer test.MockVariableValue(&setting.Service.EmailDomainAllowList, []glob.Glob{glob.MustCompile("gitea.io")})()
|
|
|
|
tt := []struct {
|
|
email string
|
|
}{
|
|
{"invalid-email"},
|
|
{"gitea.io"},
|
|
}
|
|
|
|
for _, v := range tt {
|
|
form := RegisterForm{Email: v.email}
|
|
|
|
_, ok := form.IsEmailDomainAllowed()
|
|
assert.False(t, ok)
|
|
}
|
|
}
|
|
|
|
func TestRegisterForm_IsDomainAllowed_AllowedEmail(t *testing.T) {
|
|
defer test.MockVariableValue(&setting.Service.EmailDomainAllowList, []glob.Glob{glob.MustCompile("gitea.io"), glob.MustCompile("*.allow")})()
|
|
|
|
tt := []struct {
|
|
email string
|
|
valid bool
|
|
}{
|
|
{"security@gitea.io", true},
|
|
{"security@gITea.io", true},
|
|
{"invalid", false},
|
|
{"seee@example.com", false},
|
|
|
|
{"user@my.allow", true},
|
|
{"user@my.allow1", false},
|
|
}
|
|
|
|
for _, v := range tt {
|
|
form := RegisterForm{Email: v.email}
|
|
|
|
_, ok := form.IsEmailDomainAllowed()
|
|
assert.Equal(t, v.valid, ok)
|
|
}
|
|
}
|
|
|
|
func TestRegisterForm_IsDomainAllowed_BlockedEmail(t *testing.T) {
|
|
defer test.MockVariableValue(&setting.Service.EmailDomainBlockList, []glob.Glob{glob.MustCompile("gitea.io"), glob.MustCompile("*.block")})()
|
|
|
|
tt := []struct {
|
|
email string
|
|
valid bool
|
|
}{
|
|
{"security@gitea.io", false},
|
|
{"security@gitea.example", true},
|
|
|
|
{"user@my.block", false},
|
|
{"user@my.block1", true},
|
|
}
|
|
|
|
for _, v := range tt {
|
|
form := RegisterForm{Email: v.email}
|
|
|
|
_, ok := form.IsEmailDomainAllowed()
|
|
assert.Equal(t, v.valid, ok)
|
|
}
|
|
}
|
|
|
|
func TestNewAccessTokenForm_GetScope(t *testing.T) {
|
|
tests := []struct {
|
|
form NewAccessTokenPostForm
|
|
scope auth_model.AccessTokenScope
|
|
expectedErr error
|
|
}{
|
|
{
|
|
form: NewAccessTokenPostForm{Name: "test", Scope: []string{"read:repository"}},
|
|
scope: "read:repository",
|
|
},
|
|
{
|
|
form: NewAccessTokenPostForm{Name: "test", Scope: []string{"read:repository", "write:user"}},
|
|
scope: "read:repository,write:user",
|
|
},
|
|
}
|
|
|
|
for i, test := range tests {
|
|
t.Run(strconv.Itoa(i), func(t *testing.T) {
|
|
scope, err := test.form.GetScope()
|
|
assert.Equal(t, test.expectedErr, err)
|
|
assert.Equal(t, test.scope, scope)
|
|
})
|
|
}
|
|
}
|