0ko 9ccaf473eb fix(i18n): don't log harmless missing translations as errors (#12183) ... Followup to https://codeberg.org/forgejo/forgejo/pulls/6203 Currently it is logging an error wherever a template is rendered in language that doesn't have all plural strings covered. For example, Esperanto isn't well maintained. Since more plural strings were migrated in v15 to new format, these errors became much more common. However, for all languages but the base one (English) they are completely harmless and just indicate an incomplete translation. However, for base (English) they indicate a bug in either template or en-US.json, which should be still logged as an error. The error is being logged by `LookupPluralByForm`, which is called by `TrPluralStringAllForms` and (`TrPluralString` through `LookupPluralByCount`). I originally intended to just pass log func directly to `LookupPluralByForm` from both, but since `TrPluralString` isn't calling `LookupPluralByForm` directly, it didn't look clean, so I went with passing a flag around instead and implemented logging logic in `LookupPluralByForm` itself. I little concern is with that the so-called "default lang" is configurable, and if it is configured to something with less than 100% completion, it will cause fallback bugs, as well as a lot of logging of this as an error. But this is why changing "default lang" is a bad idea in the first place, and broken fallbacks should be greater concern than junk in the logs. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/12183 Reviewed-by: Beowulf <beowulf@beocode.eu> Co-authored-by: 0ko <0ko@noreply.codeberg.org> Co-committed-by: 0ko <0ko@noreply.codeberg.org>		2026-04-18 23:18:02 +02:00
..
actions	chore: add modernizer linter (#11936)	2026-04-02 03:29:37 +02:00
activitypub	feat: backend DB model for fine-grained repo access tokens	2026-02-27 17:17:29 +01:00
analyze	Rename code_langauge.go to code_language.go (#26377)	2023-08-07 15:00:53 -04:00
assetfs	feat: optimization: use fs.ReadFile (#10987)	2026-01-22 16:26:18 +01:00
auth	chore: add modernizer linter (#11936)	2026-04-02 03:29:37 +02:00
avatar	chore: add modernizer linter (#11936)	2026-04-02 03:29:37 +02:00
base	feat(ui): dedicated icon for CITATION file (#10873)	2026-01-17 10:10:56 +01:00
cache	chore: fix typos throughout the codebase (#10753)	2026-01-26 22:57:33 +01:00
card	chore: branding import path (#7337)	2025-03-27 19:40:14 +00:00
charset	chore: add modernizer linter (#11936)	2026-04-02 03:29:37 +02:00
container	chore: add new functions to container.Set	2025-10-14 14:40:49 -06:00
csv	Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367)	2025-03-28 22:22:21 +00:00
emoji	chore(cleanup): replaces unnecessary calls to formatting functions by non-formatting equivalents (#7994)	2025-05-29 17:34:29 +02:00
eventsource	ci: detect and prevent empty case statements in Go code (#11593)	2026-03-10 02:50:28 +01:00
forgefed	chore(federation): re-enable nilnil lint (#11253)	2026-04-13 22:05:29 +02:00
generate	chore: unify the usage of CryptoRandomString (#10110)	2025-11-15 13:24:53 +01:00
git	fix: always include files set to be detectable for language stats (#11685)	2026-04-18 00:56:08 +02:00
gitrepo	Update module github.com/golangci/golangci-lint/v2/cmd/golangci-lint to v2.6.1 (forgejo) (#10053)	2025-11-11 07:04:35 +01:00
graceful	ci: detect and prevent empty case statements in Go code (#11593)	2026-03-10 02:50:28 +01:00
hcaptcha	chore: branding import path (#7337)	2025-03-27 19:40:14 +00:00
highlight	Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367)	2025-03-28 22:22:21 +00:00
hostmatcher	chore: add modernizer linter (#11936)	2026-04-02 03:29:37 +02:00
html	Refactor backend SVG package and add tests (#26335)	2023-08-05 04:34:59 +00:00
httpcache	chore: add modernizer linter (#11936)	2026-04-02 03:29:37 +02:00
httplib	chore: add modernizer linter (#11936)	2026-04-02 03:29:37 +02:00
indexer	chore: add modernizer linter (#11936)	2026-04-02 03:29:37 +02:00
issue/template	chore: add modernizer linter (#11936)	2026-04-02 03:29:37 +02:00
json	Replace interface{} with any (#25686)	2023-07-04 18:36:08 +00:00
jwtx	chore: Add JWT() method for convenience and clarity (#11067)	2026-02-07 01:01:30 +01:00
keying	fix: store pull mirror creds encrypted with keying (#11909)	2026-04-04 13:53:22 +02:00
label	chore: add modernizer linter (#11936)	2026-04-02 03:29:37 +02:00
lfs	chore: add unit test for SearchPointerBlobs	2025-10-03 14:37:24 +02:00
log	tests: make buffer log writer thread safe (#11962)	2026-04-04 16:29:14 +02:00
markup	feat(ui): Fix comma separated attributes in code blocks language preventing syntax-highlighting (#12056)	2026-04-12 18:30:30 +02:00
mcaptcha	chore: branding import path (#7337)	2025-03-27 19:40:14 +00:00
metrics	chore: branding import path (#7337)	2025-03-27 19:40:14 +00:00
migration	ci: detect and prevent empty case statements in Go code (#11593)	2026-03-10 02:50:28 +01:00
nosql	chore: branding import path (#7337)	2025-03-27 19:40:14 +00:00
optional	chore: support Option[T] as a type on database schema structs (#11553)	2026-03-08 03:36:32 +01:00
options	chore: branding import path (#7337)	2025-03-27 19:40:14 +00:00
packages	chore: add modernizer linter (#11936)	2026-04-02 03:29:37 +02:00
paginator	Use more specific test methods (#24265)	2023-04-22 17:56:27 -04:00
pprof	chore: branding import path (#7337)	2025-03-27 19:40:14 +00:00
private	chore: add modernizer linter (#11936)	2026-04-02 03:29:37 +02:00
process	Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367)	2025-03-28 22:22:21 +00:00
proxy	chore: branding import path (#7337)	2025-03-27 19:40:14 +00:00
proxyprotocol	ci: detect and prevent empty case statements in Go code (#11593)	2026-03-10 02:50:28 +01:00
public	chore: add modernizer linter (#11936)	2026-04-02 03:29:37 +02:00
queue	chore: add modernizer linter (#11936)	2026-04-02 03:29:37 +02:00
recaptcha	chore: branding import path (#7337)	2025-03-27 19:40:14 +00:00
references	fix: pull request cross references (#7979)	2025-05-28 14:50:05 +02:00
regexplru	Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367)	2025-03-28 22:22:21 +00:00
repository	chore: add modernizer linter (#11936)	2026-04-02 03:29:37 +02:00
secret	Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v1.64.6 (forgejo) (#7118)	2025-03-04 21:38:35 +00:00
session	fix: only destroy session if exists	2026-03-19 02:18:52 +01:00
setting	chore: don't load settings twice for running web (#12111)	2026-04-14 07:25:05 +02:00
sitemap	Add testifylint to lint checks (#4535)	2024-07-30 19:41:10 +00:00
ssh	fix: don't clobber authorized_keys file during installation (#10948)	2026-01-23 18:38:09 +01:00
storage	chore: use require.Error() over require.Errorf() (#11037)	2026-01-25 19:36:02 +01:00
structs	chore: add modernizer linter (#11936)	2026-04-02 03:29:37 +02:00
svg	chore: branding import path (#7337)	2025-03-27 19:40:14 +00:00
sync	chore: branding import path (#7337)	2025-03-27 19:40:14 +00:00
system	Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367)	2025-03-28 22:22:21 +00:00
templates	feat: Follow remote users; feed tab (#10380)	2026-04-12 03:31:03 +02:00
test	feat: Follow remote users; feed tab (#10380)	2026-04-12 03:31:03 +02:00
testimport	chore: move all test blank imports in a single package (#10662)	2026-01-02 05:32:32 +01:00
testlogger	chore: add modernizer linter (#11936)	2026-04-02 03:29:37 +02:00
timeutil	Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367)	2025-03-28 22:22:21 +00:00
translation	fix(i18n): don't log harmless missing translations as errors (#12183)	2026-04-18 23:18:02 +02:00
turnstile	chore: branding import path (#7337)	2025-03-27 19:40:14 +00:00
typesniffer	feat: detect Interlisp sources as text (#8377)	2025-07-02 07:38:46 +02:00
updatechecker	chore: add modernizer linter (#11936)	2026-04-02 03:29:37 +02:00
uri	Add testifylint to lint checks (#4535)	2024-07-30 19:41:10 +00:00
user	Drop SSPI auth support and more Windows files (#7148)	2025-03-08 00:43:41 +00:00
util	chore: add modernizer linter (#11936)	2026-04-02 03:29:37 +02:00
validation	chore: update github.com/go-ap/activitypub to 902f6cf (#11301)	2026-04-02 23:57:13 +02:00
web	chore: add modernizer linter (#11936)	2026-04-02 03:29:37 +02:00
webhook	Actions Failure, Succes, Recover Webhooks (#7508)	2025-06-03 14:29:19 +02:00
zstd	Cache generated binary across jobs	2024-08-26 23:43:09 +02:00