mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-05-12 22:10:25 +00:00
6ff4147688
When fetching runners, the option `WithAvailable` can be enabled to fetch all runners that can be used by a repository, user, or organization, not only those that are owned by the respective repository, user, or organization. In the instance scope, `WithAvailable` has no meaning. You always get _all_ runners. This means it is impossible to only fetch runners that are owned by the instance, but no others. This PR replaces `WithAvailable` with `WithVisible`. For repositories, users, and organizations, it has the same semantics as `WithAvailable`. For the instance scope, `WithVisible=true` equals today's default behaviour (i.e., return _all_ runners), whereas `WithVisible=false` is new and would only return the runners owned by the instance itself. The advantage of `WithVisible` is that it has a consistent meaning across all scopes. This also lays the groundwork for the introduction of a `with-visible` (tentative name) flag in the HTTP API. ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Tests for Go changes (can be removed for JavaScript changes) - I added test coverage for Go changes... - [x] in their respective `*_test.go` for unit tests. - [x] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I ran... - [x] `make pr-go` before pushing ### Tests for JavaScript changes (can be removed for Go changes) - I added test coverage for JavaScript changes... - [ ] in `web_src/js/*.test.js` if it can be unit tested. - [ ] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)). ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [ ] This change will be noticed by a Forgejo user or admin (feature, bug fix, performance, etc.). I suggest to include a release note for this change. - [x] This change is not visible to a Forgejo user or admin (refactor, dependency upgrade, etc.). I think there is no need to add a release note for this change. *The decision if the pull request will be shown in the release notes is up to the mergers / release team.* The content of the `release-notes/<pull request number>.md` file will serve as the basis for the release notes. If the file does not exist, the title of the pull request will be used instead. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/11657 Reviewed-by: Mathieu Fenniak <mfenniak@noreply.codeberg.org> Co-authored-by: Andreas Ahlenstorf <andreas@ahlenstorf.ch> Co-committed-by: Andreas Ahlenstorf <andreas@ahlenstorf.ch>
45 lines
1 KiB
YAML
45 lines
1 KiB
YAML
- id: 719931
|
|
uuid: "9e0eb762-cbdf-4725-9c90-4298568a2a77"
|
|
name: "runner-1"
|
|
version: "dev"
|
|
owner_id: 3 # Owned by org3
|
|
repo_id: 0
|
|
description: "A superb runner"
|
|
agent_labels: ["debian", "gpu"]
|
|
deleted: 0
|
|
- id: 719932
|
|
uuid: "b0a0a168-1b08-4365-95dd-e65040ca384d"
|
|
name: "runner-2"
|
|
version: "11.3.1"
|
|
owner_id: 2 # Owned by user2
|
|
repo_id: 0
|
|
description: "An exclusive runner"
|
|
agent_labels: ["docker"]
|
|
deleted: 0
|
|
- id: 719933
|
|
uuid: "974f9caf-ee64-4022-a56b-67b28ea06a0d"
|
|
name: "runner-3"
|
|
version: "12.2.0"
|
|
owner_id: 0
|
|
repo_id: 0
|
|
description: "A runner for everyone"
|
|
agent_labels: ["docker"]
|
|
deleted: 0
|
|
- id: 719934
|
|
uuid: "022650a8-e999-4a3d-afb0-21f75233798b"
|
|
name: "runner-4"
|
|
version: "12.1.0"
|
|
owner_id: 0
|
|
repo_id: 32 # owned by org3
|
|
description: ""
|
|
agent_labels: ["debian"]
|
|
deleted: 0
|
|
- id: 719935
|
|
uuid: "f3031695-87ea-41cf-8d48-21948e83ee17"
|
|
name: "runner-5"
|
|
version: "12.7.0"
|
|
owner_id: 0
|
|
repo_id: 36 # owned by user2
|
|
description: ""
|
|
agent_labels: ["arch"]
|
|
deleted: 0
|