mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-05-12 22:10:25 +00:00
This change allows the `with:` field of a reusable workflow to reference a previous job, such as `with: { some-input: "${{ needs.other-job.outputs.other-output }}" }`. `strategy.matrix` can also reference `${{ needs... }}`.
When a job is parsed and encounters this situation, the outer job of the workflow is marked with a field `incomplete_with` (or `incomplete_matrix`), indicating to Forgejo that it can't be executed as-is and the other jobs in its `needs` list need to be completed first. And then in `job_emitter.go` when one job is completed, it checks if other jobs had a `needs` reference to it and unblocks those jobs -- but if they're marked with `incomplete_with` then they can be sent back through the job parser, with the now-available job outputs, to be expanded into the correct definition of the job.
The core functionality for this already exists to allow `runs-on` and `strategy.matrix` to reference the outputs of other jobs, but it is expanded upon here to include `with` for reusable workflows.
There is one known defect in this implementation, but it has a limited scope -- if this code path is used to expand a nested reusable workflow, then the `${{ input.... }}` context will be incorrect. This will require an update to the jobparser in runner version 12.4.0, and so it is out-of-scope of this PR.
## Checklist
The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org).
### Tests
- I added test coverage for Go changes...
- [x] in their respective `*_test.go` for unit tests.
- [ ] in the `tests/integration` directory if it involves interactions with a live Forgejo server.
- I added test coverage for JavaScript changes...
- [ ] in `web_src/js/*.test.js` if it can be unit tested.
- [ ] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)).
- **end-to-end test:** will require the noted "known defect" to be resolved, but tests are authored at https://code.forgejo.org/forgejo/end-to-end/compare/main...mfenniak:expand-reusable-workflows-needs
### Documentation
- [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change.
- [x] I did not document these changes and I do not expect someone else to do it.
### Release notes
- [ ] I do not want this change to show in the release notes.
- [x] I want the title to show in the release notes with a link to this pull request.
- [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title.
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/10647
Reviewed-by: Andreas Ahlenstorf <aahlenst@noreply.codeberg.org>
Co-authored-by: Mathieu Fenniak <mathieu@fenniak.net>
Co-committed-by: Mathieu Fenniak <mathieu@fenniak.net>
308 lines
10 KiB
Go
308 lines
10 KiB
Go
// Copyright 2022 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package actions
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"slices"
|
|
"time"
|
|
|
|
"forgejo.org/models/db"
|
|
"forgejo.org/modules/container"
|
|
"forgejo.org/modules/timeutil"
|
|
"forgejo.org/modules/util"
|
|
|
|
"code.forgejo.org/forgejo/runner/v12/act/jobparser"
|
|
"go.yaml.in/yaml/v3"
|
|
"xorm.io/builder"
|
|
)
|
|
|
|
// ActionRunJob represents a job of a run
|
|
type ActionRunJob struct {
|
|
ID int64
|
|
RunID int64 `xorm:"index"`
|
|
Run *ActionRun `xorm:"-"`
|
|
RepoID int64 `xorm:"index"`
|
|
OwnerID int64 `xorm:"index"`
|
|
CommitSHA string `xorm:"index"`
|
|
IsForkPullRequest bool
|
|
Name string `xorm:"VARCHAR(255)"`
|
|
Attempt int64
|
|
WorkflowPayload []byte
|
|
JobID string `xorm:"VARCHAR(255)"` // job id in workflow, not job's id
|
|
Needs []string `xorm:"JSON TEXT"`
|
|
RunsOn []string `xorm:"JSON TEXT"`
|
|
TaskID int64 // the latest task of the job
|
|
Status Status `xorm:"index"`
|
|
Started timeutil.TimeStamp
|
|
Stopped timeutil.TimeStamp
|
|
Created timeutil.TimeStamp `xorm:"created"`
|
|
Updated timeutil.TimeStamp `xorm:"updated index"`
|
|
|
|
workflowPayloadDecoded *jobparser.SingleWorkflow `xorm:"-"`
|
|
}
|
|
|
|
func init() {
|
|
db.RegisterModel(new(ActionRunJob))
|
|
}
|
|
|
|
func (job *ActionRunJob) HTMLURL(ctx context.Context) (string, error) {
|
|
if job.Run == nil || job.Run.Repo == nil {
|
|
return "", fmt.Errorf("action_run_job: load run and repo before accessing HTMLURL")
|
|
}
|
|
|
|
// Find the "index" of the currently selected job... kinda ugly that the URL uses the index rather than some other
|
|
// unique identifier of the job which could actually be stored upon it. But hard to change that now.
|
|
allJobs, err := GetRunJobsByRunID(ctx, job.RunID)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
jobIndex := -1
|
|
for i, otherJob := range allJobs {
|
|
if job.ID == otherJob.ID {
|
|
jobIndex = i
|
|
break
|
|
}
|
|
}
|
|
if jobIndex == -1 {
|
|
return "", fmt.Errorf("action_run_job: unable to find job on run: %d", job.ID)
|
|
}
|
|
|
|
attempt := job.Attempt
|
|
// If a job has never been fetched by a runner yet, it will have attempt 0 -- but this attempt will never have a
|
|
// valid UI since attempt is incremented to 1 if it is picked up by a runner.
|
|
if attempt == 0 {
|
|
attempt = 1
|
|
}
|
|
|
|
return fmt.Sprintf("%s/actions/runs/%d/jobs/%d/attempt/%d", job.Run.Repo.HTMLURL(), job.Run.Index, jobIndex, attempt), nil
|
|
}
|
|
|
|
func (job *ActionRunJob) Duration() time.Duration {
|
|
return calculateDuration(job.Started, job.Stopped, job.Status)
|
|
}
|
|
|
|
func (job *ActionRunJob) LoadRun(ctx context.Context) error {
|
|
if job.Run == nil {
|
|
run, err := GetRunByID(ctx, job.RunID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
job.Run = run
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// LoadAttributes load Run if not loaded
|
|
func (job *ActionRunJob) LoadAttributes(ctx context.Context) error {
|
|
if job == nil {
|
|
return nil
|
|
}
|
|
|
|
if err := job.LoadRun(ctx); err != nil {
|
|
return err
|
|
}
|
|
|
|
return job.Run.LoadAttributes(ctx)
|
|
}
|
|
|
|
func (job *ActionRunJob) ItRunsOn(labels []string) bool {
|
|
if len(labels) == 0 || len(job.RunsOn) == 0 {
|
|
return false
|
|
}
|
|
labelSet := make(container.Set[string])
|
|
labelSet.AddMultiple(labels...)
|
|
return labelSet.IsSubset(job.RunsOn)
|
|
}
|
|
|
|
func GetRunJobByID(ctx context.Context, id int64) (*ActionRunJob, error) {
|
|
var job ActionRunJob
|
|
has, err := db.GetEngine(ctx).Where("id=?", id).Get(&job)
|
|
if err != nil {
|
|
return nil, err
|
|
} else if !has {
|
|
return nil, fmt.Errorf("run job with id %d: %w", id, util.ErrNotExist)
|
|
}
|
|
|
|
return &job, nil
|
|
}
|
|
|
|
func GetRunJobsByRunID(ctx context.Context, runID int64) ([]*ActionRunJob, error) {
|
|
var jobs []*ActionRunJob
|
|
if err := db.GetEngine(ctx).Where("run_id=?", runID).OrderBy("id").Find(&jobs); err != nil {
|
|
return nil, err
|
|
}
|
|
return jobs, nil
|
|
}
|
|
|
|
// All calls to UpdateRunJobWithoutNotification that change run.Status for any run from a not done status to a done status must call the ActionRunNowDone notification channel.
|
|
// Use the wrapper function UpdateRunJob instead.
|
|
func UpdateRunJobWithoutNotification(ctx context.Context, job *ActionRunJob, cond builder.Cond, cols ...string) (int64, error) {
|
|
e := db.GetEngine(ctx)
|
|
|
|
sess := e.ID(job.ID)
|
|
if len(cols) > 0 {
|
|
sess.Cols(cols...)
|
|
}
|
|
|
|
if cond != nil {
|
|
sess.Where(cond)
|
|
}
|
|
|
|
affected, err := sess.Update(job)
|
|
if err != nil {
|
|
return 0, err
|
|
}
|
|
|
|
if affected == 0 || (!slices.Contains(cols, "status") && job.Status == 0) {
|
|
return affected, nil
|
|
}
|
|
|
|
if affected != 0 && slices.Contains(cols, "status") && job.Status.IsWaiting() {
|
|
// if the status of job changes to waiting again, increase tasks version.
|
|
if err := IncreaseTaskVersion(ctx, job.OwnerID, job.RepoID); err != nil {
|
|
return 0, err
|
|
}
|
|
}
|
|
|
|
if job.RunID == 0 {
|
|
var err error
|
|
if job, err = GetRunJobByID(ctx, job.ID); err != nil {
|
|
return 0, err
|
|
}
|
|
}
|
|
|
|
{
|
|
// Other goroutines may aggregate the status of the run and update it too.
|
|
// So we need load the run and its jobs before updating the run.
|
|
run, err := GetRunByID(ctx, job.RunID)
|
|
if err != nil {
|
|
return 0, err
|
|
}
|
|
jobs, err := GetRunJobsByRunID(ctx, job.RunID)
|
|
if err != nil {
|
|
return 0, err
|
|
}
|
|
run.Status = AggregateJobStatus(jobs)
|
|
if run.Started.IsZero() && run.Status.IsRunning() {
|
|
run.Started = timeutil.TimeStampNow()
|
|
}
|
|
if run.Stopped.IsZero() && run.Status.IsDone() {
|
|
run.Stopped = timeutil.TimeStampNow()
|
|
}
|
|
// As the caller has to ensure the ActionRunNowDone notification is sent we can ignore doing so here.
|
|
if err := UpdateRunWithoutNotification(ctx, run, "status", "started", "stopped"); err != nil {
|
|
return 0, fmt.Errorf("update run %d: %w", run.ID, err)
|
|
}
|
|
}
|
|
|
|
return affected, nil
|
|
}
|
|
|
|
func AggregateJobStatus(jobs []*ActionRunJob) Status {
|
|
allSuccessOrSkipped := len(jobs) != 0
|
|
allSkipped := len(jobs) != 0
|
|
var hasFailure, hasCancelled, hasWaiting, hasRunning, hasBlocked bool
|
|
for _, job := range jobs {
|
|
allSuccessOrSkipped = allSuccessOrSkipped && (job.Status == StatusSuccess || job.Status == StatusSkipped)
|
|
allSkipped = allSkipped && job.Status == StatusSkipped
|
|
hasFailure = hasFailure || job.Status == StatusFailure
|
|
hasCancelled = hasCancelled || job.Status == StatusCancelled
|
|
hasWaiting = hasWaiting || job.Status == StatusWaiting
|
|
hasRunning = hasRunning || job.Status == StatusRunning
|
|
hasBlocked = hasBlocked || job.Status == StatusBlocked
|
|
}
|
|
switch {
|
|
case allSkipped:
|
|
return StatusSkipped
|
|
case allSuccessOrSkipped:
|
|
return StatusSuccess
|
|
case hasCancelled:
|
|
return StatusCancelled
|
|
case hasFailure:
|
|
return StatusFailure
|
|
case hasRunning:
|
|
return StatusRunning
|
|
case hasWaiting:
|
|
return StatusWaiting
|
|
case hasBlocked:
|
|
return StatusBlocked
|
|
default:
|
|
return StatusUnknown // it shouldn't happen
|
|
}
|
|
}
|
|
|
|
// Retrieves the parsed workflow for this specific job. This field is often accessed multiple times in succession, so
|
|
// the parsed content is cached in-memory on the `ActionRunJob` instance.
|
|
func (job *ActionRunJob) DecodeWorkflowPayload() (*jobparser.SingleWorkflow, error) {
|
|
if job.workflowPayloadDecoded != nil {
|
|
return job.workflowPayloadDecoded, nil
|
|
}
|
|
|
|
var jobWorkflow jobparser.SingleWorkflow
|
|
err := yaml.Unmarshal(job.WorkflowPayload, &jobWorkflow)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failure unmarshaling WorkflowPayload to SingleWorkflow: %w", err)
|
|
}
|
|
|
|
job.workflowPayloadDecoded = &jobWorkflow
|
|
return job.workflowPayloadDecoded, nil
|
|
}
|
|
|
|
// If `WorkflowPayload` is changed on an `ActionRunJob`, clear any cached decoded version of the payload. Typically
|
|
// only used for unit tests.
|
|
func (job *ActionRunJob) ClearCachedWorkflowPayload() {
|
|
job.workflowPayloadDecoded = nil
|
|
}
|
|
|
|
// Checks whether the target job is an `(incomplete matrix)` job that will be blocked until the matrix is complete, and
|
|
// then regenerated and deleted. If it is incomplete, and if the information is available, the specific job and/or
|
|
// output that causes it to be incomplete will be returned as well.
|
|
func (job *ActionRunJob) HasIncompleteMatrix() (bool, *jobparser.IncompleteNeeds, error) {
|
|
jobWorkflow, err := job.DecodeWorkflowPayload()
|
|
if err != nil {
|
|
return false, nil, fmt.Errorf("failure decoding workflow payload: %w", err)
|
|
}
|
|
return jobWorkflow.IncompleteMatrix, jobWorkflow.IncompleteMatrixNeeds, nil
|
|
}
|
|
|
|
// Checks whether the target job has a `runs-on` field with an expression that requires an input from another job. The
|
|
// job will be blocked until the other job is complete, and then regenerated and deleted.
|
|
func (job *ActionRunJob) HasIncompleteRunsOn() (bool, *jobparser.IncompleteNeeds, *jobparser.IncompleteMatrix, error) {
|
|
jobWorkflow, err := job.DecodeWorkflowPayload()
|
|
if err != nil {
|
|
return false, nil, nil, fmt.Errorf("failure decoding workflow payload: %w", err)
|
|
}
|
|
return jobWorkflow.IncompleteRunsOn, jobWorkflow.IncompleteRunsOnNeeds, jobWorkflow.IncompleteRunsOnMatrix, nil
|
|
}
|
|
|
|
// Check whether the target job was generated as a result of expanding a reusable workflow.
|
|
func (job *ActionRunJob) IsWorkflowCallInnerJob() (bool, error) {
|
|
jobWorkflow, err := job.DecodeWorkflowPayload()
|
|
if err != nil {
|
|
return false, fmt.Errorf("failure decoding workflow payload: %w", err)
|
|
}
|
|
return jobWorkflow.Metadata.WorkflowCallParent != "", nil
|
|
}
|
|
|
|
// Check whether this job is a caller of a reusable workflow -- in other words, the real work done in this job is in
|
|
// spawned child jobs, not this job.
|
|
func (job *ActionRunJob) IsWorkflowCallOuterJob() (bool, error) {
|
|
jobWorkflow, err := job.DecodeWorkflowPayload()
|
|
if err != nil {
|
|
return false, fmt.Errorf("failure decoding workflow payload: %w", err)
|
|
}
|
|
return jobWorkflow.Metadata.WorkflowCallID != "", nil
|
|
}
|
|
|
|
// Checks whether the target job has a `with` field with an expression that requires an input from another job. The job
|
|
// will be blocked until the other job is complete, and then regenerated and deleted.
|
|
func (job *ActionRunJob) HasIncompleteWith() (bool, *jobparser.IncompleteNeeds, *jobparser.IncompleteMatrix, error) {
|
|
jobWorkflow, err := job.DecodeWorkflowPayload()
|
|
if err != nil {
|
|
return false, nil, nil, fmt.Errorf("failure decoding workflow payload: %w", err)
|
|
}
|
|
return jobWorkflow.IncompleteWith, jobWorkflow.IncompleteWithNeeds, jobWorkflow.IncompleteWithMatrix, nil
|
|
}
|