mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-05-12 22:10:25 +00:00
Allow JWTs that are generated by Forgejo Actions to be validated within Forgejo in-memory. Without any special support for this internal access situation, these problems would occur: 1. Forgejo would need to make an HTTP request to itself to get the valid public key for the JWT, in order to validate its signature. This is a waste of resources, and introduces a self-DoS risk. 2. Forgejo would need to be available via TLS in order for Actions to make service calls to Forgejo with that JWT, due to the TLS requirement for public key fetching. This would be a blocker for writing end-to-end tests for Forgejo, but also would affect users who do not host Forgejo with TLS. 3. Authorized Integrations would need to be saved with the `issuer` URL of Forgejo. If Forgejo's own `setting.AppURL` changed, all the persisted records in the database would become incorrect. ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. All work and communication must conform to Forgejo's [AI Agreement](https://codeberg.org/forgejo/governance/src/branch/main/AIAgreement.md). There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Tests for Go changes - I added test coverage for Go changes... - [x] in their respective `*_test.go` for unit tests. - [x] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I ran... - [x] `make pr-go` before pushing ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [ ] This change will be noticed by a Forgejo user or admin (feature, bug fix, performance, etc.). I suggest to include a release note for this change. - [x] This change is not visible to a Forgejo user or admin (refactor, dependency upgrade, etc.). I think there is no need to add a release note for this change. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/12364 Reviewed-by: Andreas Ahlenstorf <aahlenst@noreply.codeberg.org>
210 lines
5.7 KiB
Go
210 lines
5.7 KiB
Go
// Copyright 2026 The Forgejo Authors. All rights reserved.
|
|
// SPDX-License-Identifier: GPL-3.0-or-later
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"os"
|
|
"strings"
|
|
|
|
auth_model "forgejo.org/models/auth"
|
|
"forgejo.org/models/db"
|
|
"forgejo.org/models/repo"
|
|
user_model "forgejo.org/models/user"
|
|
"forgejo.org/modules/json"
|
|
"forgejo.org/services/authz"
|
|
|
|
"github.com/urfave/cli/v3"
|
|
)
|
|
|
|
func microcmdUserCreateAuthorizedIntegration() *cli.Command {
|
|
return &cli.Command{
|
|
Name: "create-authorized-integration",
|
|
Description: `Creates an authorized integration. Authorized integrations allow Forgejo to
|
|
receive JWTs from external sources, validate their claims against
|
|
user-defined rules, and grant access to Forgejo's API on behalf of a user.
|
|
|
|
The issuer may be set to "urn:forgejo:authorized-integrations:actions"
|
|
to support JWTs from the local instance's Forgejo Actions, utilizing the
|
|
enable-openid-connect flag in a workflow.`,
|
|
Flags: []cli.Flag{
|
|
&cli.StringFlag{
|
|
Name: "username",
|
|
Aliases: []string{"u"},
|
|
Usage: "Username",
|
|
Required: true,
|
|
},
|
|
|
|
// JWT validation:
|
|
&cli.StringFlag{
|
|
Name: "issuer",
|
|
Usage: `JWT issuer ('iss' claim), example: https://forgejo.example.org/api/actions`,
|
|
Required: true,
|
|
},
|
|
&cli.StringMapFlag{
|
|
Name: "claim-eq",
|
|
Value: map[string]string{},
|
|
Usage: `Zero-or-more claim equality checks, formatted as claim=value, example: "actor=someuser"`,
|
|
},
|
|
&cli.StringMapFlag{
|
|
Name: "claim-glob",
|
|
Value: map[string]string{},
|
|
Usage: `Zero-or-more claim glob checks, formatted as claim=value, example: "sub=repo:forgejo/*:pull_request"`,
|
|
},
|
|
// nested claim support omitted for now -- pretty complex for a CLI
|
|
|
|
// Permissions available on successful auth:
|
|
&cli.StringSliceFlag{
|
|
Name: "scope",
|
|
Value: []string{"all"},
|
|
Usage: `One-or-more scopes to apply to access token, examples: "all", "read:issue", "write:repository"`,
|
|
},
|
|
&cli.StringSliceFlag{
|
|
Name: "repo",
|
|
Value: []string{"all"},
|
|
Usage: `Zero-or-more specific repositories that can be accessed, or "all" to allow access to all repositories, example: "owner1/repo1"`,
|
|
},
|
|
},
|
|
Before: noDanglingArgs,
|
|
Action: runCreateAuthorizedIntegration,
|
|
}
|
|
}
|
|
|
|
func runCreateAuthorizedIntegration(ctx context.Context, c *cli.Command) error {
|
|
if !c.IsSet("username") {
|
|
return errors.New("you must provide a username to generate a token for")
|
|
}
|
|
|
|
ctx, cancel := installSignals(ctx)
|
|
defer cancel()
|
|
|
|
if err := initDB(ctx); err != nil {
|
|
return err
|
|
}
|
|
|
|
user, err := user_model.GetUserByName(ctx, c.String("username"))
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
ai := &auth_model.AuthorizedIntegration{
|
|
UserID: user.ID,
|
|
}
|
|
|
|
var rules []auth_model.ClaimRule
|
|
ai.Issuer = c.String("issuer")
|
|
for claim, value := range c.StringMap("claim-eq") {
|
|
rules = append(rules, auth_model.ClaimRule{
|
|
Claim: claim,
|
|
Comparison: auth_model.ClaimEqual,
|
|
Value: value,
|
|
})
|
|
}
|
|
for claim, value := range c.StringMap("claim-glob") {
|
|
rules = append(rules, auth_model.ClaimRule{
|
|
Claim: claim,
|
|
Comparison: auth_model.ClaimGlob,
|
|
Value: value,
|
|
})
|
|
}
|
|
ai.ClaimRules = &auth_model.ClaimRules{Rules: rules}
|
|
|
|
scopes := strings.Join(c.StringSlice("scope"), ",")
|
|
accessTokenScope, err := auth_model.AccessTokenScope(scopes).Normalize()
|
|
if err != nil {
|
|
return fmt.Errorf("invalid access token scope provided: %w", err)
|
|
}
|
|
ai.Scope = accessTokenScope
|
|
|
|
allRepos := false
|
|
repos := []*repo.Repository{}
|
|
for _, repoName := range c.StringSlice("repo") {
|
|
if repoName == "all" {
|
|
allRepos = true
|
|
} else {
|
|
split := strings.Split(repoName, "/")
|
|
if len(split) != 2 {
|
|
return fmt.Errorf("invalid repo name: %q", split)
|
|
}
|
|
owner := split[0]
|
|
name := split[1]
|
|
repo, err := repo.GetRepositoryByOwnerAndName(ctx, owner, name)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
repos = append(repos, repo)
|
|
}
|
|
}
|
|
ai.ResourceAllRepos = allRepos
|
|
|
|
rr := make([]*auth_model.AuthorizedIntegResourceRepo, len(repos))
|
|
for i := range repos {
|
|
rr[i] = &auth_model.AuthorizedIntegResourceRepo{RepoID: repos[i].ID}
|
|
}
|
|
if err := authz.ValidateAuthorizedIntegration(ai, rr); err != nil {
|
|
return err
|
|
}
|
|
|
|
err = db.WithTx(ctx, func(ctx context.Context) error {
|
|
if err := auth_model.InsertAuthorizedIntegration(ctx, ai); err != nil {
|
|
return err
|
|
}
|
|
if !allRepos {
|
|
if err := auth_model.InsertAuthorizedIntegrationResourceRepos(ctx, ai.ID, rr); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
return nil
|
|
})
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
type ClaimRuleDescription struct {
|
|
Description string `json:"description"`
|
|
Claim string `json:"claim"`
|
|
Comparison auth_model.ClaimComparison `json:"compare"`
|
|
Value string `json:"value"`
|
|
}
|
|
output := struct {
|
|
Message string `json:"message"`
|
|
Issuer string `json:"issuer"`
|
|
Audience string `json:"audience"`
|
|
ClaimRules []ClaimRuleDescription `json:"claim_rules"`
|
|
}{
|
|
Message: "Authorized integration was successfully created.",
|
|
Issuer: ai.Issuer,
|
|
Audience: ai.Audience,
|
|
}
|
|
for _, cr := range ai.ClaimRules.Rules {
|
|
var description string
|
|
switch cr.Comparison {
|
|
case auth_model.ClaimEqual:
|
|
description = fmt.Sprintf("%q = %q", cr.Claim, cr.Value)
|
|
case auth_model.ClaimGlob:
|
|
description = fmt.Sprintf("%q matches %q", cr.Claim, cr.Value)
|
|
}
|
|
output.ClaimRules = append(output.ClaimRules, ClaimRuleDescription{
|
|
Description: description,
|
|
Claim: cr.Claim,
|
|
Comparison: cr.Comparison,
|
|
Value: cr.Value,
|
|
})
|
|
}
|
|
|
|
raw, err := json.Marshal(output)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
var indent bytes.Buffer
|
|
if err := json.Indent(&indent, raw, "", " "); err != nil {
|
|
return err
|
|
}
|
|
os.Stdout.Write(indent.Bytes())
|
|
|
|
return nil
|
|
}
|