jojo/models/db/context_test.go
Mathieu Fenniak e823e8cd69 fix: duplicate key violates unique constraint in concurrent debian package uploads (#11776)
Fixes #11438.

Whenever a "unique constraint violation" error is encountered by package mutation, detect if a `xorm.ErrUniqueConstraintViolation` error occurs.  If it does, retry the entire transaction.

## Checklist

The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org).

### Tests for Go changes

(can be removed for JavaScript changes)

- I added test coverage for Go changes...
  - [ ] in their respective `*_test.go` for unit tests.
  - [ ] in the `tests/integration` directory if it involves interactions with a live Forgejo server.
- I ran...
  - [ ] `make pr-go` before pushing

### Documentation

- [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change.
- [x] I did not document these changes and I do not expect someone else to do it.

### Release notes

- [x] This change will be noticed by a Forgejo user or admin (feature, bug fix, performance, etc.). I suggest to include a release note for this change.
- [ ] This change is not visible to a Forgejo user or admin (refactor, dependency upgrade, etc.). I think there is no need to add a release note for this change.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/11776
Reviewed-by: Andreas Ahlenstorf <aahlenst@noreply.codeberg.org>
Co-authored-by: Mathieu Fenniak <mathieu@fenniak.net>
Co-committed-by: Mathieu Fenniak <mathieu@fenniak.net>
2026-03-26 21:50:25 +01:00

278 lines
6.8 KiB
Go

// Copyright 2022 The Gitea Authors. All rights reserved.
// SPDX-License-Identifier: MIT
package db_test
import (
"context"
"errors"
"fmt"
"testing"
"forgejo.org/models/db"
issues_model "forgejo.org/models/issues"
"forgejo.org/models/unittest"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestInTransaction(t *testing.T) {
require.NoError(t, unittest.PrepareTestDatabase())
assert.False(t, db.InTransaction(db.DefaultContext))
require.NoError(t, db.WithTx(db.DefaultContext, func(ctx context.Context) error {
assert.True(t, db.InTransaction(ctx))
return nil
}))
ctx, committer, err := db.TxContext(db.DefaultContext)
require.NoError(t, err)
defer committer.Close()
assert.True(t, db.InTransaction(ctx))
require.NoError(t, db.WithTx(ctx, func(ctx context.Context) error {
assert.True(t, db.InTransaction(ctx))
return nil
}))
}
func TestTxContext(t *testing.T) {
require.NoError(t, unittest.PrepareTestDatabase())
{ // create new transaction
ctx, committer, err := db.TxContext(db.DefaultContext)
require.NoError(t, err)
assert.True(t, db.InTransaction(ctx))
require.NoError(t, committer.Commit())
}
{ // reuse the transaction created by TxContext and commit it
ctx, committer, err := db.TxContext(db.DefaultContext)
engine := db.GetEngine(ctx)
require.NoError(t, err)
assert.True(t, db.InTransaction(ctx))
{
ctx, committer, err := db.TxContext(ctx)
require.NoError(t, err)
assert.True(t, db.InTransaction(ctx))
assert.Equal(t, engine, db.GetEngine(ctx))
require.NoError(t, committer.Commit())
}
require.NoError(t, committer.Commit())
}
{ // reuse the transaction created by TxContext and close it
ctx, committer, err := db.TxContext(db.DefaultContext)
engine := db.GetEngine(ctx)
require.NoError(t, err)
assert.True(t, db.InTransaction(ctx))
{
ctx, committer, err := db.TxContext(ctx)
require.NoError(t, err)
assert.True(t, db.InTransaction(ctx))
assert.Equal(t, engine, db.GetEngine(ctx))
require.NoError(t, committer.Close())
}
require.NoError(t, committer.Close())
}
{ // reuse the transaction created by WithTx
require.NoError(t, db.WithTx(db.DefaultContext, func(ctx context.Context) error {
assert.True(t, db.InTransaction(ctx))
{
ctx, committer, err := db.TxContext(ctx)
require.NoError(t, err)
assert.True(t, db.InTransaction(ctx))
require.NoError(t, committer.Commit())
}
return nil
}))
}
t.Run("Reuses parent context", func(t *testing.T) {
type unique struct{}
ctx := context.WithValue(db.DefaultContext, unique{}, "yes!")
assert.False(t, db.InTransaction(ctx))
require.NoError(t, db.WithTx(ctx, func(ctx context.Context) error {
assert.Equal(t, "yes!", ctx.Value(unique{}))
return nil
}))
})
}
func TestAfterTx(t *testing.T) {
tests := []struct {
executionMode string
rollback bool
}{
{
executionMode: "NoTx",
},
{
executionMode: "WithTx",
},
{
executionMode: "WithTxNested",
},
{
executionMode: "WithTx",
rollback: true,
},
{
executionMode: "WithTxNested",
rollback: true,
},
{
executionMode: "TxContext",
},
{
executionMode: "TxContextNested",
},
{
executionMode: "TxContext",
rollback: true,
},
{
executionMode: "TxContextNested",
rollback: true,
},
}
for _, tc := range tests {
t.Run(fmt.Sprintf("%s/%v", tc.executionMode, tc.rollback), func(t *testing.T) {
require.NoError(t, unittest.PrepareTestDatabase())
ctx := t.Context()
var err error
var countBefore, countAfter, hookCount int64
countBefore, err = db.GetEngine(ctx).Count(&issues_model.PullRequest{})
require.NoError(t, err)
sut := func(ctx context.Context) {
_, err = db.GetEngine(ctx).Insert(
&issues_model.PullRequest{IssueID: 2, BaseRepoID: 1, HeadRepoID: 1000})
require.NoError(t, err)
db.AfterTx(ctx, func() {
countAfter, err = db.GetEngine(ctx).Count(&issues_model.PullRequest{})
require.NoError(t, err)
assert.False(t, db.InTransaction(ctx))
hookCount++
})
}
switch tc.executionMode {
case "NoTx":
sut(ctx)
case "WithTx":
db.WithTx(ctx, func(ctx context.Context) error {
sut(ctx)
if tc.rollback {
return errors.New("rollback")
}
return nil
})
case "WithTxNested":
db.WithTx(ctx, func(ctx context.Context) error {
return db.WithTx(ctx, func(ctx context.Context) error {
sut(ctx)
if tc.rollback {
return errors.New("rollback")
}
return nil
})
})
case "TxContext":
txCtx, committer, err := db.TxContext(ctx)
require.NoError(t, err)
sut(txCtx)
if !tc.rollback {
err = committer.Commit()
require.NoError(t, err)
}
committer.Close()
case "TxContextNested":
txCtx1, committer1, err := db.TxContext(ctx)
require.NoError(t, err)
txCtx2, committer2, err := db.TxContext(txCtx1)
require.NoError(t, err)
sut(txCtx2)
err = committer2.Commit()
require.NoError(t, err)
committer2.Close()
if !tc.rollback {
err = committer1.Commit()
require.NoError(t, err)
}
committer1.Close()
default:
t.Fatalf("unexpected execution mode: %q", tc.executionMode)
}
if tc.rollback {
assert.EqualValues(t, 0, hookCount)
assert.EqualValues(t, 0, countAfter)
} else {
assert.EqualValues(t, 1, hookCount)
assert.Equal(t, countBefore+1, countAfter)
}
})
}
}
func TestRetryTx(t *testing.T) {
t.Run("success", func(t *testing.T) {
err := db.RetryTx(t.Context(), db.RetryConfig{AttemptCount: 1}, func(ctx context.Context) error {
assert.True(t, db.InTransaction(ctx))
return nil
})
require.NoError(t, err)
})
t.Run("fail constantly", func(t *testing.T) {
attemptCount := 0
testError := errors.New("hello")
err := db.RetryTx(t.Context(), db.RetryConfig{
AttemptCount: 2,
ErrorIs: []error{testError},
}, func(ctx context.Context) error {
attemptCount++
return testError
})
require.ErrorIs(t, err, testError)
require.ErrorContains(t, err, "2 attempts")
assert.Equal(t, 2, attemptCount)
})
t.Run("fail w/ non retriable error", func(t *testing.T) {
attemptCount := 0
testError := errors.New("hello")
err := db.RetryTx(t.Context(), db.RetryConfig{
AttemptCount: 2,
ErrorIs: []error{},
}, func(ctx context.Context) error {
attemptCount++
return testError
})
require.ErrorIs(t, err, testError)
assert.Equal(t, 1, attemptCount)
})
t.Run("succeed on retry", func(t *testing.T) {
attemptCount := 0
testError := errors.New("hello")
err := db.RetryTx(t.Context(), db.RetryConfig{
AttemptCount: 2,
ErrorIs: []error{testError},
}, func(ctx context.Context) error {
attemptCount++
if attemptCount == 1 {
return testError
}
return nil
})
require.NoError(t, err)
assert.Equal(t, 2, attemptCount)
})
}