mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-05-17 08:16:35 +00:00
Replace the anti-CSRF token with a [cross origin protection by Go](https://go.dev/doc/go1.25#nethttppkgnethttp) that uses a stateless way of verifying if a request was cross origin or not. This allows is to remove al lot of code and replace it with a few lines of code and we no longer have to hand roll this protection. The new protection uses indicators by the browser itself that indicate if the request is cross-origin, thus we no longer have to take care of ensuring the generated CSRF token is passed back to the server any request by the the browser will have send this indicator. Resolves forgejo/forgejo#3538 Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/9830 Reviewed-by: oliverpool <oliverpool@noreply.codeberg.org> Reviewed-by: Mathieu Fenniak <mfenniak@noreply.codeberg.org> Co-authored-by: Gusted <postmaster@gusted.xyz> Co-committed-by: Gusted <postmaster@gusted.xyz>
212 lines
5.4 KiB
Go
212 lines
5.4 KiB
Go
// Copyright 2018 The Gitea Authors. All rights reserved.
|
||
// SPDX-License-Identifier: MIT
|
||
|
||
package integration
|
||
|
||
import (
|
||
"net/http"
|
||
"net/url"
|
||
"path"
|
||
"testing"
|
||
|
||
"forgejo.org/tests"
|
||
|
||
"github.com/stretchr/testify/assert"
|
||
)
|
||
|
||
func testSrcRouteRedirect(t *testing.T, session *TestSession, user, repo, route, expectedLocation string, expectedStatus int) {
|
||
prefix := path.Join("/", user, repo, "src")
|
||
|
||
// Make request
|
||
req := NewRequest(t, "GET", path.Join(prefix, route))
|
||
resp := session.MakeRequest(t, req, http.StatusSeeOther)
|
||
|
||
// Check Location header
|
||
location := resp.Header().Get("Location")
|
||
assert.Equal(t, path.Join(prefix, expectedLocation), location)
|
||
|
||
// Perform redirect
|
||
req = NewRequest(t, "GET", location)
|
||
session.MakeRequest(t, req, expectedStatus)
|
||
}
|
||
|
||
func setDefaultBranch(t *testing.T, session *TestSession, user, repo, branch string) {
|
||
location := path.Join("/", user, repo, "settings/branches")
|
||
req := NewRequestWithValues(t, "POST", location, map[string]string{
|
||
"action": "default_branch",
|
||
"branch": branch,
|
||
})
|
||
session.MakeRequest(t, req, http.StatusSeeOther)
|
||
}
|
||
|
||
func TestNonasciiBranches(t *testing.T) {
|
||
testRedirects := []struct {
|
||
from string
|
||
to string
|
||
status int
|
||
}{
|
||
// Branches
|
||
{
|
||
from: "master",
|
||
to: "branch/master",
|
||
status: http.StatusOK,
|
||
},
|
||
{
|
||
from: "master/README.md",
|
||
to: "branch/master/README.md",
|
||
status: http.StatusOK,
|
||
},
|
||
{
|
||
from: "master/badfile",
|
||
to: "branch/master/badfile",
|
||
status: http.StatusNotFound, // it does not exists
|
||
},
|
||
{
|
||
from: "ГлавнаяВетка",
|
||
to: "branch/%D0%93%D0%BB%D0%B0%D0%B2%D0%BD%D0%B0%D1%8F%D0%92%D0%B5%D1%82%D0%BA%D0%B0",
|
||
status: http.StatusOK,
|
||
},
|
||
{
|
||
from: "а/б/в",
|
||
to: "branch/%D0%B0/%D0%B1/%D0%B2",
|
||
status: http.StatusOK,
|
||
},
|
||
{
|
||
from: "Grüßen/README.md",
|
||
to: "branch/Gr%C3%BC%C3%9Fen/README.md",
|
||
status: http.StatusOK,
|
||
},
|
||
{
|
||
from: "Plus+Is+Not+Space",
|
||
to: "branch/Plus+Is+Not+Space",
|
||
status: http.StatusOK,
|
||
},
|
||
{
|
||
from: "Plus+Is+Not+Space/Файл.md",
|
||
to: "branch/Plus+Is+Not+Space/%D0%A4%D0%B0%D0%B9%D0%BB.md",
|
||
status: http.StatusOK,
|
||
},
|
||
{
|
||
from: "Plus+Is+Not+Space/and+it+is+valid.md",
|
||
to: "branch/Plus+Is+Not+Space/and+it+is+valid.md",
|
||
status: http.StatusOK,
|
||
},
|
||
{
|
||
from: "ブランチ",
|
||
to: "branch/%E3%83%96%E3%83%A9%E3%83%B3%E3%83%81",
|
||
status: http.StatusOK,
|
||
},
|
||
// Tags
|
||
{
|
||
from: "Тэг",
|
||
to: "tag/%D0%A2%D1%8D%D0%B3",
|
||
status: http.StatusOK,
|
||
},
|
||
{
|
||
from: "Ё/人",
|
||
to: "tag/%D0%81/%E4%BA%BA",
|
||
status: http.StatusOK,
|
||
},
|
||
{
|
||
from: "タグ",
|
||
to: "tag/%E3%82%BF%E3%82%B0",
|
||
status: http.StatusOK,
|
||
},
|
||
{
|
||
from: "タグ/ファイル.md",
|
||
to: "tag/%E3%82%BF%E3%82%B0/%E3%83%95%E3%82%A1%E3%82%A4%E3%83%AB.md",
|
||
status: http.StatusOK,
|
||
},
|
||
// Files
|
||
{
|
||
from: "README.md",
|
||
to: "branch/Plus+Is+Not+Space/README.md",
|
||
status: http.StatusOK,
|
||
},
|
||
{
|
||
from: "Файл.md",
|
||
to: "branch/Plus+Is+Not+Space/%D0%A4%D0%B0%D0%B9%D0%BB.md",
|
||
status: http.StatusOK,
|
||
},
|
||
{
|
||
from: "ファイル.md",
|
||
to: "branch/Plus+Is+Not+Space/%E3%83%95%E3%82%A1%E3%82%A4%E3%83%AB.md",
|
||
status: http.StatusNotFound, // it's not on default branch
|
||
},
|
||
// Same but url-encoded (few tests)
|
||
{
|
||
from: "%E3%83%96%E3%83%A9%E3%83%B3%E3%83%81",
|
||
to: "branch/%E3%83%96%E3%83%A9%E3%83%B3%E3%83%81",
|
||
status: http.StatusOK,
|
||
},
|
||
{
|
||
from: "%E3%82%BF%E3%82%b0",
|
||
to: "tag/%E3%82%BF%E3%82%B0",
|
||
status: http.StatusOK,
|
||
},
|
||
{
|
||
from: "%D0%A4%D0%B0%D0%B9%D0%BB.md",
|
||
to: "branch/Plus+Is+Not+Space/%D0%A4%D0%B0%D0%B9%D0%BB.md",
|
||
status: http.StatusOK,
|
||
},
|
||
{
|
||
from: "%D0%81%2F%E4%BA%BA",
|
||
to: "tag/%D0%81/%E4%BA%BA",
|
||
status: http.StatusOK,
|
||
},
|
||
{
|
||
from: "Ё%2F%E4%BA%BA",
|
||
to: "tag/%D0%81/%E4%BA%BA",
|
||
status: http.StatusOK,
|
||
},
|
||
{
|
||
from: "Plus+Is+Not+Space/%25%252525mightnotplaywell",
|
||
to: "branch/Plus+Is+Not+Space/%25%252525mightnotplaywell",
|
||
status: http.StatusOK,
|
||
},
|
||
{
|
||
from: "Plus+Is+Not+Space/%25253Fisnotaquestion%25253F",
|
||
to: "branch/Plus+Is+Not+Space/%25253Fisnotaquestion%25253F",
|
||
status: http.StatusOK,
|
||
},
|
||
{
|
||
from: "Plus+Is+Not+Space/" + url.PathEscape("%3Fis?and#afile"),
|
||
to: "branch/Plus+Is+Not+Space/" + url.PathEscape("%3Fis?and#afile"),
|
||
status: http.StatusOK,
|
||
},
|
||
{
|
||
from: "Plus+Is+Not+Space/10%25.md",
|
||
to: "branch/Plus+Is+Not+Space/10%25.md",
|
||
status: http.StatusOK,
|
||
},
|
||
{
|
||
from: "Plus+Is+Not+Space/" + url.PathEscape("This+file%20has 1space"),
|
||
to: "branch/Plus+Is+Not+Space/" + url.PathEscape("This+file%20has 1space"),
|
||
status: http.StatusOK,
|
||
},
|
||
{
|
||
from: "Plus+Is+Not+Space/" + url.PathEscape("This+file%2520has 2 spaces"),
|
||
to: "branch/Plus+Is+Not+Space/" + url.PathEscape("This+file%2520has 2 spaces"),
|
||
status: http.StatusOK,
|
||
},
|
||
{
|
||
from: "Plus+Is+Not+Space/" + url.PathEscape("£15&$6.txt"),
|
||
to: "branch/Plus+Is+Not+Space/" + url.PathEscape("£15&$6.txt"),
|
||
status: http.StatusOK,
|
||
},
|
||
}
|
||
|
||
defer tests.PrepareTestEnv(t)()
|
||
|
||
user := "user2"
|
||
repo := "utf8"
|
||
session := loginUser(t, user)
|
||
|
||
setDefaultBranch(t, session, user, repo, "Plus+Is+Not+Space")
|
||
|
||
for _, test := range testRedirects {
|
||
testSrcRouteRedirect(t, session, user, repo, test.from, test.to, test.status)
|
||
}
|
||
|
||
setDefaultBranch(t, session, user, repo, "master")
|
||
}
|