jojo/templates
0ko d05002fbfb fix(ui): prevent JS from removing icon from close/reopen button (#9959)
Followup to https://codeberg.org/forgejo/forgejo/pulls/9598. A bug surfaced.

When typing text in, JS was updating button's `textContent`, which also affected the icon included in the button. To avoid complex rebuilding of the button element in JS I just placed the text it it's own span, `textContent` of which is now updated by JS instead of the whole button.

Preview

Normal state from template:
https://codeberg.org/attachments/f504bcc3-c1bc-4b10-96ae-e8b666c4a828
https://codeberg.org/attachments/5e72109c-04c7-49b0-ba05-e8f17c949fcb

After editing text, without the fix:
https://codeberg.org/attachments/2c61b02f-b36a-4b80-8816-98bed3fc48e0
https://codeberg.org/attachments/923d4419-97ee-48c6-b60d-9719e36ae6ff

With the fix:
https://codeberg.org/attachments/458c1f6a-549e-4ef7-8822-8529351b7bc4
https://codeberg.org/attachments/839032f7-2f4a-488a-a8a5-d3fbfc45504b

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/9959
Reviewed-by: Otto <otto@codeberg.org>
2025-11-05 05:02:52 +01:00
..
admin feat: replace cross origin protection (#9830) 2025-10-29 22:43:22 +01:00
api/packages/pypi Update templates/api/packages/pypi/simple.tmpl 2024-04-12 16:43:30 +00:00
base feat: replace cross origin protection (#9830) 2025-10-29 22:43:22 +01:00
custom [FEAT] Repository flags 2024-02-05 16:09:42 +01:00
devtest feat(ui): dangerous buttons (#9652) 2025-10-20 12:03:17 +02:00
explore feat(ui): allow dropdown to contain not just items (#9951) 2025-11-05 05:00:15 +01:00
htmx fix(ui): Make 'Clear milestone' work with HTMX (#8266) 2025-08-11 20:10:10 +02:00
mail fix: release email links (#9690) 2025-10-16 16:12:32 +02:00
moderation feat: replace cross origin protection (#9830) 2025-10-29 22:43:22 +01:00
org feat(ui): allow dropdown to contain not just items (#9951) 2025-11-05 05:00:15 +01:00
package feat: replace cross origin protection (#9830) 2025-10-29 22:43:22 +01:00
projects feat: replace cross origin protection (#9830) 2025-10-29 22:43:22 +01:00
repo fix(ui): prevent JS from removing icon from close/reopen button (#9959) 2025-11-05 05:02:52 +01:00
shared feat(ui): allow dropdown to contain not just items (#9951) 2025-11-05 05:00:15 +01:00
status fix(ui): remove extra helpers from statuspages (#9753) 2025-10-20 12:03:58 +02:00
swagger feat: Add admin individual user email management endpoints (#9594) 2025-10-28 15:52:37 +01:00
user feat: replace cross origin protection (#9830) 2025-10-29 22:43:22 +01:00
webhook feat: replace cross origin protection (#9830) 2025-10-29 22:43:22 +01:00
home.tmpl Split Forgejo landing page template to allow patching or removing Forgejo introduction section (#6675) 2025-02-03 08:41:52 +00:00
home_forgejo.tmpl Split Forgejo landing page template to allow patching or removing Forgejo introduction section (#6675) 2025-02-03 08:41:52 +00:00
install.tmpl Added alt's to <img> 2025-01-31 21:22:00 +00:00
post-install.tmpl [BRANDING] Custom loading animation for Forgejo 2024-02-05 16:02:13 +01:00