jojo/models/activities/notification_test.go
Gusted d1cef852ee feat: rework notification table (#9926)
This change is motivated by 5e300a2a87

- Drop the `updated_by` and `commit_id` column, they are unused and have a index for no reason.
- Drop the index on `status` and `created_unix` and make a index on `(user_id, status)`.

## Test
1. Run migration.
2. Confirm the migration succeeds.
3. Check that `notification` table has the correct indexes.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/9926
Reviewed-by: Mathieu Fenniak <mfenniak@noreply.codeberg.org>
Co-authored-by: Gusted <postmaster@gusted.xyz>
Co-committed-by: Gusted <postmaster@gusted.xyz>
2025-11-29 23:03:56 +01:00

177 lines
6.7 KiB
Go

// Copyright 2017 The Gitea Authors. All rights reserved.
// Copyright 2025 The Forgejo Authors. All rights reserved.
// SPDX-License-Identifier: MIT
package activities
import (
"context"
"testing"
"time"
"forgejo.org/models/db"
issues_model "forgejo.org/models/issues"
"forgejo.org/models/unittest"
user_model "forgejo.org/models/user"
"forgejo.org/modules/timeutil"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestCreateOrUpdateIssueNotifications(t *testing.T) {
require.NoError(t, unittest.PrepareTestDatabase())
issue := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 1})
require.NoError(t, CreateOrUpdateIssueNotifications(db.DefaultContext, issue.ID, 0, 2, 0))
// User 9 is inactive, thus notifications for user 1 and 4 are created
notf := unittest.AssertExistsAndLoadBean(t, &Notification{UserID: 1, IssueID: issue.ID})
assert.Equal(t, NotificationStatusUnread, notf.Status)
unittest.CheckConsistencyFor(t, &issues_model.Issue{ID: issue.ID})
notf = unittest.AssertExistsAndLoadBean(t, &Notification{UserID: 4, IssueID: issue.ID})
assert.Equal(t, NotificationStatusUnread, notf.Status)
}
func TestNotificationsForUser(t *testing.T) {
require.NoError(t, unittest.PrepareTestDatabase())
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
notfs, err := db.Find[Notification](db.DefaultContext, FindNotificationOptions{
UserID: user.ID,
Status: []NotificationStatus{
NotificationStatusRead,
NotificationStatusUnread,
},
})
require.NoError(t, err)
if assert.Len(t, notfs, 3) {
assert.EqualValues(t, 5, notfs[0].ID)
assert.Equal(t, user.ID, notfs[0].UserID)
assert.EqualValues(t, 4, notfs[1].ID)
assert.Equal(t, user.ID, notfs[1].UserID)
assert.EqualValues(t, 2, notfs[2].ID)
assert.Equal(t, user.ID, notfs[2].UserID)
}
}
func TestNotification_GetRepo(t *testing.T) {
require.NoError(t, unittest.PrepareTestDatabase())
notf := unittest.AssertExistsAndLoadBean(t, &Notification{RepoID: 1})
repo, err := notf.GetRepo(db.DefaultContext)
require.NoError(t, err)
assert.Equal(t, repo, notf.Repository)
assert.Equal(t, notf.RepoID, repo.ID)
}
func TestNotification_GetIssue(t *testing.T) {
require.NoError(t, unittest.PrepareTestDatabase())
notf := unittest.AssertExistsAndLoadBean(t, &Notification{RepoID: 1})
issue, err := notf.GetIssue(db.DefaultContext)
require.NoError(t, err)
assert.Equal(t, issue, notf.Issue)
assert.Equal(t, notf.IssueID, issue.ID)
}
func TestGetNotificationCount(t *testing.T) {
require.NoError(t, unittest.PrepareTestDatabase())
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 1})
cnt, err := db.Count[Notification](db.DefaultContext, FindNotificationOptions{
UserID: user.ID,
Status: []NotificationStatus{
NotificationStatusRead,
},
})
require.NoError(t, err)
assert.EqualValues(t, 0, cnt)
cnt, err = db.Count[Notification](db.DefaultContext, FindNotificationOptions{
UserID: user.ID,
Status: []NotificationStatus{
NotificationStatusUnread,
},
})
require.NoError(t, err)
assert.EqualValues(t, 1, cnt)
}
func TestSetNotificationStatus(t *testing.T) {
require.NoError(t, unittest.PrepareTestDatabase())
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
notf := unittest.AssertExistsAndLoadBean(t,
&Notification{UserID: user.ID, Status: NotificationStatusRead})
_, err := SetNotificationStatus(db.DefaultContext, notf.ID, user, NotificationStatusPinned)
require.NoError(t, err)
unittest.AssertExistsAndLoadBean(t,
&Notification{ID: notf.ID, Status: NotificationStatusPinned})
_, err = SetNotificationStatus(db.DefaultContext, 1, user, NotificationStatusRead)
require.Error(t, err)
_, err = SetNotificationStatus(db.DefaultContext, unittest.NonexistentID, user, NotificationStatusRead)
require.Error(t, err)
}
func TestUpdateNotificationStatuses(t *testing.T) {
require.NoError(t, unittest.PrepareTestDatabase())
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
notfUnread := unittest.AssertExistsAndLoadBean(t,
&Notification{UserID: user.ID, Status: NotificationStatusUnread})
notfRead := unittest.AssertExistsAndLoadBean(t,
&Notification{UserID: user.ID, Status: NotificationStatusRead})
notfPinned := unittest.AssertExistsAndLoadBean(t,
&Notification{UserID: user.ID, Status: NotificationStatusPinned})
require.NoError(t, UpdateNotificationStatuses(db.DefaultContext, user, NotificationStatusUnread, NotificationStatusRead))
unittest.AssertExistsAndLoadBean(t,
&Notification{ID: notfUnread.ID, Status: NotificationStatusRead})
unittest.AssertExistsAndLoadBean(t,
&Notification{ID: notfRead.ID, Status: NotificationStatusRead})
unittest.AssertExistsAndLoadBean(t,
&Notification{ID: notfPinned.ID, Status: NotificationStatusPinned})
}
func TestSetIssueReadBy(t *testing.T) {
require.NoError(t, unittest.PrepareTestDatabase())
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 1})
issue := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 1})
require.NoError(t, db.WithTx(db.DefaultContext, func(ctx context.Context) error {
return SetIssueReadBy(ctx, issue.ID, user.ID)
}))
nt, err := GetIssueNotification(db.DefaultContext, user.ID, issue.ID)
require.NoError(t, err)
assert.Equal(t, NotificationStatusRead, nt.Status)
}
func TestUpdateIssueNotification(t *testing.T) {
require.NoError(t, unittest.PrepareTestDatabase())
now := time.Date(2025, 1, 1, 0, 0, 0, 0, time.UTC)
timeutil.MockSet(now)
defer timeutil.MockUnset()
t.Run("Read notification", func(t *testing.T) {
require.NoError(t, updateIssueNotification(t.Context(), 1, 1, 1001))
notification := unittest.AssertExistsAndLoadBean(t, &Notification{UserID: 1, IssueID: 1})
assert.Equal(t, NotificationStatusUnread, notification.Status)
assert.EqualValues(t, 0, notification.CommentID)
assert.Equal(t, timeutil.TimeStamp(now.Unix()), notification.UpdatedUnix)
})
t.Run("Unread notification", func(t *testing.T) {
beforeUpdateUnix := unittest.AssertExistsAndLoadBean(t, &Notification{UserID: 2, IssueID: 2}).UpdatedUnix
require.NoError(t, updateIssueNotification(t.Context(), 2, 2, 1001))
notification := unittest.AssertExistsAndLoadBean(t, &Notification{UserID: 2, IssueID: 2})
assert.Equal(t, NotificationStatusUnread, notification.Status)
assert.EqualValues(t, 1001, notification.CommentID)
assert.NotEqual(t, beforeUpdateUnix, notification.UpdatedUnix)
})
t.Run("Pinned notification", func(t *testing.T) {
require.NoError(t, updateIssueNotification(t.Context(), 1, 1, 1001))
notification := unittest.AssertExistsAndLoadBean(t, &Notification{UserID: 1, IssueID: 1})
assert.Equal(t, NotificationStatusUnread, notification.Status)
assert.EqualValues(t, 0, notification.CommentID)
assert.Equal(t, timeutil.TimeStamp(now.Unix()), notification.UpdatedUnix)
})
}