mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-05-14 15:00:25 +00:00
ca32cd3f8a
When manually triggering a Forgejo Actions workflow, Forgejo always assumed the workflow directory to be `.forgejo/workflows`, even if the workflows were found in `.gitea/workflows` or `.github/workflows`. As a consequence, the executed workflows were misidentified in the UI. Furthermore, the context variable `${{ forgejo.workflow_ref }}`, which contains the full path to the workflow file, pointed to a non-existent file. The workflow directory is now determined dynamically. Existing database entries are left unmodified.
The screenshot shows the old behaviour for run 3 and the new, correct behaviour for run 4.
The PR is marked as WIP because it requires https://codeberg.org/forgejo/forgejo/pulls/10276 to be merged first.
## Checklist
The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org).
### Tests
- I added test coverage for Go changes...
- [x] in their respective `*_test.go` for unit tests.
- [x] in the `tests/integration` directory if it involves interactions with a live Forgejo server.
- I added test coverage for JavaScript changes...
- [ ] in `web_src/js/*.test.js` if it can be unit tested.
- [ ] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)).
### Documentation
- [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change.
- [x] I did not document these changes and I do not expect someone else to do it.
### Release notes
- [ ] I do not want this change to show in the release notes.
- [ ] I want the title to show in the release notes with a link to this pull request.
- [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title.
<!--start release-notes-assistant-->
## Release notes
<!--URL:https://codeberg.org/forgejo/forgejo-->
- Bug fixes
- [PR](https://codeberg.org/forgejo/forgejo/pulls/10411): <!--number 10411 --><!--line 0 --><!--description Zml4KGFjdGlvbnMpOiByZXBsYWNlIGhhcmRjb2RlZCB3aXRoIGR5bmFtaWNhbGx5IGRldGVybWluZWQgd29ya2Zsb3cgZGlyZWN0b3J5-->fix(actions): replace hardcoded with dynamically determined workflow directory<!--description-->
<!--end release-notes-assistant-->
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/10411
Reviewed-by: Mathieu Fenniak <mfenniak@noreply.codeberg.org>
Reviewed-by: Cyborus <cyborus@disroot.org>
Co-authored-by: Andreas Ahlenstorf <andreas@ahlenstorf.ch>
Co-committed-by: Andreas Ahlenstorf <andreas@ahlenstorf.ch>
|
||
|---|---|---|
| .. | ||
| Test_tryHandleIncompleteMatrix | ||
| TestActions_CancelOrApproveRun | ||
| TestActions_consistencyCheckRun | ||
| TestActionsNotifier_IsTrusted | ||
| TestActionsTrust_GetPullRequestUserIsTrustedWithActions | ||
| TestCancelPreviousJobs | ||
| TestCancelPreviousWithConcurrencyGroup | ||
| TestServiceActions_startTask | ||
| TestServicesActions_TransferLingeringLogs | ||
| auth.go | ||
| auth_test.go | ||
| cleanup.go | ||
| cleanup_test.go | ||
| clear_tasks.go | ||
| commit_status.go | ||
| commit_status_test.go | ||
| context.go | ||
| context_test.go | ||
| init.go | ||
| interface.go | ||
| job_emitter.go | ||
| job_emitter_test.go | ||
| log.go | ||
| log_test.go | ||
| main_test.go | ||
| notifier.go | ||
| notifier_helper.go | ||
| notifier_helper_test.go | ||
| rerun.go | ||
| rerun_test.go | ||
| run.go | ||
| run_test.go | ||
| schedule_tasks.go | ||
| schedule_tasks_test.go | ||
| task.go | ||
| trust.go | ||
| trust_test.go | ||
| variables.go | ||
| variables_test.go | ||
| workflows.go | ||
| workflows_test.go | ||