mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2026-05-12 22:10:25 +00:00
e919aedcec
**Backport:** https://codeberg.org/forgejo/forgejo/pulls/11843 Fixes #11842. The `once: true` was likely added to prevent multiple concurrent submissions of the same form. This could still be worth preventing, but I suspect it would require wrapping the supplied `onApprove` callback with the corresponding logic, implemented manually, as I am not aware of any native API to prevent concurrent executions of callbacks. ## Checklist ### Tests for JavaScript changes - I added test coverage for JavaScript changes... - [ ] in `web_src/js/*.test.js` if it can be unit tested. - [x] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)). ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [x] This change will be noticed by a Forgejo user or admin (feature, bug fix, performance, etc.). I suggest to include a release note for this change. - [ ] This change is not visible to a Forgejo user or admin (refactor, dependency upgrade, etc.). I think there is no need to add a release note for this change. Co-authored-by: Antonin Delpeuch <antonin@delpeuch.eu> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/11931 Reviewed-by: Mathieu Fenniak <mfenniak@noreply.codeberg.org> Co-authored-by: forgejo-backport-action <forgejo-backport-action@noreply.codeberg.org> Co-committed-by: forgejo-backport-action <forgejo-backport-action@noreply.codeberg.org>
63 lines
2.4 KiB
TypeScript
63 lines
2.4 KiB
TypeScript
// Copyright 2025 The Forgejo Authors. All rights reserved.
|
|
// SPDX-License-Identifier: GPL-3.0-or-later
|
|
|
|
// @watch start
|
|
// templates/repo/issues/labels/**
|
|
// web_src/js/features/comp/LabelEdit.js
|
|
// @watch end
|
|
|
|
import {expect} from '@playwright/test';
|
|
import {test, dynamic_id} from './utils_e2e.ts';
|
|
import {screenshot} from './shared/screenshots.ts';
|
|
|
|
test.use({user: 'user2'});
|
|
|
|
test('New label', async ({page}) => {
|
|
const response = await page.goto('/user2/repo1/labels');
|
|
expect(response?.status()).toBe(200);
|
|
|
|
await page.getByRole('button', {name: 'New label'}).click();
|
|
await expect(page.locator('#new-label-modal')).toBeVisible();
|
|
await screenshot(page, page.locator('#new-label-modal'));
|
|
|
|
const labelName = dynamic_id();
|
|
await page.getByRole('textbox', {name: 'Label name'}).fill(labelName);
|
|
await page.getByRole('button', {name: 'Create label'}).click();
|
|
|
|
await expect(page.locator('.label-title').filter({hasText: labelName})).toBeVisible();
|
|
});
|
|
|
|
test('Edit label', async ({page}) => {
|
|
const response = await page.goto('/user2/repo1/labels');
|
|
expect(response?.status()).toBe(200);
|
|
|
|
await page.getByText('Edit').first().click();
|
|
await expect(page.locator('#edit-label-modal')).toBeVisible();
|
|
await screenshot(page, page.locator('#edit-label-modal'));
|
|
|
|
const labelName = dynamic_id();
|
|
await page.getByRole('textbox', {name: 'Label name'}).fill(labelName);
|
|
await page.getByRole('button', {name: 'Save'}).click();
|
|
|
|
await expect(page.locator('.label-title').filter({hasText: labelName})).toBeVisible();
|
|
});
|
|
|
|
test('New label after a failed validation', async ({page}) => {
|
|
// for issue https://codeberg.org/forgejo/forgejo/issues/11842
|
|
const response = await page.goto('/user2/repo1/labels');
|
|
expect(response?.status()).toBe(200);
|
|
|
|
await page.getByRole('button', {name: 'New label'}).click();
|
|
await expect(page.locator('#new-label-modal')).toBeVisible();
|
|
|
|
// attempt to submit the form without having filled it first
|
|
await page.getByRole('button', {name: 'Create label'}).click();
|
|
await screenshot(page, page.locator('#new-label-modal'));
|
|
|
|
// then fill the form and submit it again
|
|
const labelName = dynamic_id();
|
|
await page.getByRole('textbox', {name: 'Label name'}).fill(labelName);
|
|
await page.getByRole('button', {name: 'Create label'}).click();
|
|
|
|
await expect(page.locator('.label-title').filter({hasText: labelName})).toBeVisible();
|
|
});
|